From: Andy Whitcroft <apw@shadowen.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Adrian Bunk <bunk@kernel.org>,
mingo@elte.hu, a.p.zijlstra@chello.nl,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
sam@ravnborg.org, viro@ftp.linux.org.uk, hpa@zytor.com
Subject: Re: [rfc] the kernel workflow & trivial "global -> static" patches (was: Re: [2.6 patch] make sched_feat_{names,open} static)
Date: Tue, 6 May 2008 08:46:55 +0100 [thread overview]
Message-ID: <20080506074636.GA27480@shadowen.org> (raw)
In-Reply-To: <20080505144625.2abc8e63@infradead.org>
On Mon, May 05, 2008 at 02:46:25PM -0700, Arjan van de Ven wrote:
> On Mon, 5 May 2008 14:26:04 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > Actually, we could perhaps do a lot of this at the checkpatch level?
> > If checkpatch sees a global symbol being added and the same patch
> > does not add references to that symbol from a different file then
> > whine. Obviously this will generate false positives but that's OK.
>
> or.. doesn't add it to a header file. That might be even more generic;
> (and enforces a "all global functions need a prototype in a header
> somewhere)
That does sound possible. I am sure it will false positive quite a lot,
but its probabally worth a stab.
-apw
next prev parent reply other threads:[~2008-05-06 7:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 18:29 [2.6 patch] make sched_feat_{names,open} static Adrian Bunk
2008-05-05 20:19 ` [rfc] the kernel workflow & trivial "global -> static" patches (was: Re: [2.6 patch] make sched_feat_{names,open} static) Ingo Molnar
2008-05-05 20:40 ` Randy.Dunlap
2008-05-05 21:51 ` Arjan van de Ven
2008-05-05 23:19 ` david
2008-05-05 23:40 ` Arjan van de Ven
2008-05-05 23:45 ` Theodore Tso
2008-05-06 3:23 ` Arjan van de Ven
2008-05-06 5:48 ` Arjan van de Ven
2008-05-05 20:42 ` Andrew Morton
2008-05-05 21:07 ` Adrian Bunk
2008-05-05 21:26 ` Andrew Morton
2008-05-05 21:45 ` Adrian Bunk
2008-05-05 21:46 ` Arjan van de Ven
2008-05-06 7:46 ` Andy Whitcroft [this message]
2008-05-05 21:02 ` Adrian Bunk
2008-05-06 0:21 ` [rfc] the kernel workflow & trivial "global -> static" patches Andi Kleen
2008-05-06 6:18 ` Adrian Bunk
2008-05-06 11:13 ` Andi Kleen
2008-05-06 11:25 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506074636.GA27480@shadowen.org \
--to=apw@shadowen.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=bunk@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox