From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: paulmck@us.ibm.com, joe@perches.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm][v2] ratelimit rewrite
Date: Tue, 6 May 2008 12:24:23 -0700 [thread overview]
Message-ID: <20080506122423.051b4254.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080506022558.GA2904@darkstar.te-china.tietoenator.com>
On Tue, 6 May 2008 10:25:58 +0800
Dave Young <hidave.darkstar@gmail.com> wrote:
> [Fixed a macro error found by davem, added more changes description.]
>
> ---
> All ratelimit user use same jiffies and burst params, so some messages
> (callbacks) will be lost.
>
> For example:
> a call printk_ratelimit(5 * HZ, 1)
> b call printk_ratelimit(5 * HZ, 1) before the 5*HZ timeout of a, then b will
> will be supressed.
>
> Changes:
> 1. rewrite __ratelimit, and use a ratelimit_state as parameter.
> Thanks for hints from andrew.
> 2. change WARN_ON_SECS to WARN_ON_RATELIMIT, update rcupreempt.h
> 3. remove __printk_ratelimit
> 4. use __ratelimit in net_ratelimit
I rebased this on top of mainline+linux-next+mm-stuff. I'll drop
add-warn_on_secs-macro.patch and use-warn_on_secs-in-rcupreempth.patch
next prev parent reply other threads:[~2008-05-06 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 2:25 [PATCH -mm][v2] ratelimit rewrite Dave Young
2008-05-06 19:24 ` Andrew Morton [this message]
2008-05-08 19:25 ` Andrew Morton
2008-05-08 23:19 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506122423.051b4254.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hidave.darkstar@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox