The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <clameter@sgi.com>
Cc: travis@sgi.com, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: x86: Unify current.h
Date: Tue, 6 May 2008 14:51:28 +0200	[thread overview]
Message-ID: <20080506125128.GA5051@elte.hu> (raw)
In-Reply-To: <20080506122841.GK32591@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Christoph Lameter <clameter@sgi.com> wrote:
> 
> > There are just two definitions that are shared but the resulting 
> > combined file is resonably small. Putting these two arch headers 
> > together shows that further unifications requires a unification of the 
> > per cpu / pda handling between both arches (zero based or some 
> > variation thereof).
> > 
> > Signed-off-by: Christoph Lameter <clameter@sgi.com>
> 
> applied, thanks Christoph.

x86.git testing found a build failure due to this patch:

  include/asm/current.h: Assembler messages:
  include/asm/current.h:4: Error: no such instruction: `struct task_struct'

with this config:

  http://redhat.com/~mingo/misc/config-Tue_May__6_14_45_51_CEST_2008.bad

i suspect the __ASSEMBLY__ protections in the unified file are not wide 
enough?

	Ingo

  reply	other threads:[~2008-05-06 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 18:48 x86: Unify current.h Christoph Lameter
2008-05-06 12:28 ` Ingo Molnar
2008-05-06 12:51   ` Ingo Molnar [this message]
2008-05-06 18:00     ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080506125128.GA5051@elte.hu \
    --to=mingo@elte.hu \
    --cc=clameter@sgi.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox