From: David Miller <davem@davemloft.net>
To: linux-kernel@vger.kernel.org
Cc: jengelh@computergmbh.de, adaplas@pol.net, hpa@zytor.com,
alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org,
torvalds@linux-foundation.org
Subject: 2.6.26-rcX VC console scrolling regression
Date: Wed, 07 May 2008 21:46:37 -0700 (PDT) [thread overview]
Message-ID: <20080507.214637.193700986.davem@davemloft.net> (raw)
This change:
commit c9e587abfdec2c2aaa55fab83bcb4972e2f84f9b
Author: Jan Engelhardt <jengelh@computergmbh.de>
Date: Tue Apr 29 00:59:46 2008 -0700
vt: fix background color on line feed
A command that causes a line feed while a background color is active,
such as
perl -e 'print "x" x 60, "\e[44m", "x" x 40, "\e[0m\n"'
and
perl -e 'print "x" x 40, "\e[44m\n", "x" x 40, "\e[0m\n"'
causes the line that was started as a result of the line feed to be completely
filled with the currently active background color instead of the default
color.
When scrolling, part of the current screen is memcpy'd/memmove'd to the new
region, and the new line(s) that will appear as a result are cleared using
memset. However, the lines are cleared with vc->vc_video_erase_char, causing
them to be colored with the currently active background color. This is
different from X11 terminal emulators which always paint the new lines with
the default background color (e.g. `xterm -bg black`).
The clear operation (\e[1J and \e[2J) also use vc_video_erase_char, so a new
vc->vc_scrl_erase_char is introduced with contains the erase character used
for scrolling, which is built from vc->vc_def_color instead of vc->vc_color.
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Causes garbage characters to appear at the end of lines on my VCs when
scrolling.
They look like lowercase 'c' characters with a '.' above them, and they
are colored light blue. The rest of the console text is fine.
I think it might be because my VC gets put into a UTF8 mode or something
like that via the init scripts? It seems to start happening right when
the init scripts print "Setting up console font and keymap", which seems
to come from /etc/init.d/console-setup which runs /bin/setupcon
This is with a stock Ubuntu 7.10 installation.
next reply other threads:[~2008-05-08 4:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 4:46 David Miller [this message]
2008-05-08 6:02 ` 2.6.26-rcX VC console scrolling regression Andrew Morton
2008-05-08 15:04 ` Linus Torvalds
2008-05-08 9:13 ` Jan Engelhardt
2008-05-08 9:21 ` David Miller
2008-05-08 11:50 ` Jan Engelhardt
2008-05-09 6:26 ` David Miller
2008-05-09 19:24 ` Jan Engelhardt
2008-05-09 21:55 ` David Miller
2008-05-10 7:48 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507.214637.193700986.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adaplas@pol.net \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox