public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Carlos R. Mafra" <crmafra2@gmail.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: rtc-cmos.c: Build fix
Date: Wed, 7 May 2008 14:31:15 -0700	[thread overview]
Message-ID: <20080507143115.ed738026.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080506185125.GA12844@beyonder.ift.unesp.br>

On Tue, 6 May 2008 15:51:25 -0300
"Carlos R. Mafra" <crmafra2@gmail.com> wrote:

> Subject: [PATCH] rtc-cmos.c: Build fix
> 
> The function hpet_rtc_interrupt(..) is to be used only if CONFIG_HPET_EMULATE_RTC
> is defined (see arch/x86/kernel/hpet.c), so we define it to return 0 when
> !CONFIG_HPET_EMULATE_RTC to avoid build failures. 
> 
> This function will never be used anyways when !CONFIG_HPET_EMULATE_RTC because 
> it is inside a if(is_hpet_enabled()) which is never true when
> !CONFIG_HPET_EMULATE_RTC.

I've lost the plot on this one.  Could we please have a description of
the problem which is being fixed?  ie, the compiler (or linker?) output,
and a description of why it is occurring?

Thanks.

  parent reply	other threads:[~2008-05-07 21:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 23:11 x86: Clean up computation of HPET .mult variables Carlos R. Mafra
2008-05-05 23:58 ` Daniel Walker
2008-05-06  2:13   ` Carlos R. Mafra
2008-05-06  3:23     ` Daniel Walker
2008-05-06 12:59       ` Carlos R. Mafra
2008-05-06 16:21         ` Daniel Walker
2008-05-06 20:50           ` Carlos R. Mafra
2008-05-07  2:17             ` Daniel Walker
2008-05-07  3:39               ` Carlos R. Mafra
2008-05-07  4:21                 ` Daniel Walker
2008-05-07  7:13             ` Ingo Molnar
2008-05-06 12:43 ` Ingo Molnar
2008-05-06 13:13   ` Carlos R. Mafra
2008-05-06 18:51   ` rtc-cmos.c: Build fix Carlos R. Mafra
2008-05-07  7:10     ` Ingo Molnar
2008-05-07 21:31     ` Andrew Morton [this message]
2008-05-09  8:32       ` Ingo Molnar
2008-05-09 12:33         ` Carlos R. Mafra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080507143115.ed738026.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=crmafra2@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox