Re: volanoMark regression with kernel 2.6.26-rc1

Peter Zijlstra
2008-05-08T06:44:23Z

On Thu, 2008-05-08 at 13:20 +0800, Zhang, Yanmin wrote:
> On Wed, 2008-05-07 at 19:34 +0200, Peter Zijlstra wrote:
> > On Wed, 2008-05-07 at 11:17 +0200, Ingo Molnar wrote:
> > > * Zhang, Yanmin <yanmin_zhang@linux.intel.com> wrote:
> > >
> > > > Comparing with 2.6.25, volanoMark has big regression with kernel
> > > > 2.6.26-rc1. It's about 50% on my 8-core stoakley, 16-core tigerton,
> > > > and Itanium Montecito.
> > > >
> > > > With bisect, I located below patch.
> > >
> > > thanks Yanmin, i've queued up your patch that reverts this change.
> >
> > Is this really needed now that GROUP_SCHED defaults to 'n' ?
> >
> > Yanmin, this is with GROUP_SCHED=y, right or is this without?
> With GROUP_SCHED=y.
>
> I remember a similiar patch was merged into 2.6.25-rc1 and I found the similiar volanoMark
> regression, then you reverted it. Why to add it back to 2.6.26-rc1?

The only thing similar is that it tries to to SMP load balancing for
groups, other than that there is nothing similar - its a total rewrite
with a whole different approach.

And we _need_ an SMP load-balancer for groups - otherwise group
scheduling is just not complete.