From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759795AbYEGX7G (ORCPT ); Wed, 7 May 2008 19:59:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755332AbYEGX6w (ORCPT ); Wed, 7 May 2008 19:58:52 -0400 Received: from mho-02-bos.mailhop.org ([63.208.196.179]:54783 "EHLO mho-02-bos.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753785AbYEGX6u (ORCPT ); Wed, 7 May 2008 19:58:50 -0400 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 69.181.40.92 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+Zug1VXhRAWJENvxQNcexs Date: Wed, 7 May 2008 16:58:47 -0700 From: Tony Lindgren To: Kyungmin Park Cc: linux-omap@vger.kernel.org, LKML , paul@pwsan.com Subject: Re: vanilla kernel is broken on omap board Message-ID: <20080507235847.GV18682@atomide.com> References: <9c9fda240805061748n3287cb24v530f779b6b622d53@mail.gmail.com> <20080507011914.GM18682@atomide.com> <20080507234401.GU18682@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080507234401.GU18682@atomide.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [080507 16:47]: > * Tony Lindgren [080506 18:19]: > > Hi, > > > > * Kyungmin Park [080506 17:48]: > > > Hi Tony, > > > > > > Current vanilla kernel is broken on omap2 boards. > > > In the previous time you committed some omap2 patches, but some > > > patches are not missing. > > > Such as Runtime constants series. [1] > > > > > > Now "some parts" are already included. > > > So you just commit the remain parts too such as in [2] > > > In most cases the board files don't set the their own global variables. > > > > Well at least we're getting closer to making omap2 really usable with > > mainline kernel :) > > > > Thanks for fixing that, will add this to omap-fixes queue and send it > > upstream with bunch of other fixes. > > Kyungmin, can you reply with your Signed-off-by for this patch? Actually, I'll use Paul's patch 2b256e28e8e70592f0c38a862cc4ba0498c9db7b from linux-omap tree like you suggested so we already have s-o-b. Tony > > > > > Regards, > > > > Tony > > > > > > > Thank you, > > > Kyungmin Park > > > > > > 1. Runtime constants: introduce omap2_set_globals_*() > > > http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=2b256e28e8e70592f0c38a862cc4ba0498c9db7b > > > Runtime constants: use runtime-computed SDRC base > > > http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=7b5f8cdb222052a7aa02ed38c59e0af1946b1e06 > > > Runtime constants: use runtime-computed SMS base > > > http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commitdiff;h=80ccf4b99eb3892809bbebf7673bdd1a359d56ff > > > > > > 2. > > > diff --git a/arch/arm/mach-omap2/board-apollon.c b/arch/arm/mach-omap2/board-apo > > > index a1e1e67..620fa0f 100644 > > > --- a/arch/arm/mach-omap2/board-apollon.c > > > +++ b/arch/arm/mach-omap2/board-apollon.c > > > @@ -394,6 +394,7 @@ static void __init omap_apollon_init(void) > > > > > > static void __init omap_apollon_map_io(void) > > > { > > > + omap2_set_globals_242x(); > > > omap2_map_common_io(); > > > } > > > diff --git a/include/asm-arm/arch-omap/common.h b/include/asm-arm/arch-omap/comm > > > index 224e009..36a3b62 100644 > > > --- a/include/asm-arm/arch-omap/common.h > > > +++ b/include/asm-arm/arch-omap/common.h > > > @@ -47,4 +47,8 @@ static inline int omap_register_i2c_bus(int bus_id, u32 clkrat > > > } > > > #endif > > > > > > +void omap2_set_globals_242x(void); > > > +void omap2_set_globals_243x(void); > > > +void omap2_set_globals_343x(void); > > > + > > > #endif /* __ARCH_ARM_MACH_OMAP_COMMON_H */ > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html