From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>, Paul Menage <menage@google.com>,
Jeremy Fitzhardinge <jeremy@xensource.com>,
Andi Kleen <ak@suse.de>, LKML <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] call_usermodehelper_setup() should use GFP_KERNEL
Date: Thu, 8 May 2008 01:29:57 -0700 [thread overview]
Message-ID: <20080508012957.c778c8e7.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080508163039.0EF4.KOSAKI.MOTOHIRO@jp.fujitsu.com>
On Thu, 08 May 2008 16:31:29 +0900 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > KOSAKI Motohiro wrote:
> > > Now, call_usermodehelper_setup() use GFP_ATOMIC.
> > > but it is slighly odd.
> > > because call_usermodehelper() is always called process context.
> > >
> >
> > Are you sure? I found the following call chain:
> >
> > static irqreturn_t power_handler(int irq, void *dev_id)
> > ->orderly_poweroff(true);
> > ->call_usermodehelper_setup()
>
> sorry, you are right.
> I'll make patch again.
How many times do we have to make this mistake :(
Only the caller knows what allocation mode the callee can use.
call_usermodehelper_setup() should be extended to take a gfp_t argument.
next prev parent reply other threads:[~2008-05-08 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 6:41 [PATCH] call_usermodehelper_setup() should use GFP_KERNEL KOSAKI Motohiro
2008-05-08 7:23 ` Li Zefan
2008-05-08 7:31 ` KOSAKI Motohiro
2008-05-08 8:29 ` Andrew Morton [this message]
2008-05-08 9:40 ` KOSAKI Motohiro
2008-05-08 10:16 ` Jeremy Fitzhardinge
2008-05-08 10:38 ` KOSAKI Motohiro
2008-05-08 12:58 ` Jeremy Fitzhardinge
2008-05-08 23:46 ` KOSAKI Motohiro
2008-05-08 23:53 ` Jeremy Fitzhardinge
2008-05-09 0:04 ` KOSAKI Motohiro
2008-05-09 0:08 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508012957.c778c8e7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=jeremy@xensource.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox