From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932135AbYEHSfY (ORCPT ); Thu, 8 May 2008 14:35:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755499AbYEHSfI (ORCPT ); Thu, 8 May 2008 14:35:08 -0400 Received: from 1wt.eu ([62.212.114.60]:4253 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754714AbYEHSfG (ORCPT ); Thu, 8 May 2008 14:35:06 -0400 Date: Thu, 8 May 2008 20:33:24 +0200 From: Willy Tarreau To: Greg KH Cc: linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Len Brown Subject: Re: [patch 00/16] Linux 2.6.25 -stable review Message-ID: <20080508183324.GA1874@1wt.eu> References: <20080508174122.GA855@suse.de> <20080508181342.GA1594@1wt.eu> <20080508182233.GB2115@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080508182233.GB2115@suse.de> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 08, 2008 at 11:22:33AM -0700, Greg KH wrote: > On Thu, May 08, 2008 at 08:13:42PM +0200, Willy Tarreau wrote: > > On Thu, May 08, 2008 at 10:41:22AM -0700, Greg KH wrote: > > > This is the start of the stable review cycle for the 2.6.25.2 release. > > > There are 16 patches in this series, all will be posted as a response to > > > this one. If anyone has any issues with these being applied, please let > > > us know. If anyone is a maintainer of the proper subsystem, and wants > > > to add a Signed-off-by: line to the patch, please respond with it. > > > > Greg, shouldn't we also queue this one (may be in a later version) ? It's > > in mainline. > > What problem does it solve? from what I see in the code, currently acpi_power_get_state() will return 0 when setting resource to NULL, and some callers (eg: acpi_power_on()) will happily dereference resource if acpi_power_get_state() returns 0. So I guess there are circumstances where we can oops. > Does Len want it in -stable? I simply forgot to ask. I'm CCing him. Willy > thanks, > > greg k-h > > > >From a815ab8b5891f3d2515316655729272f68269e3b Mon Sep 17 00:00:00 2001 > > From: Li Zefan > > Date: Fri, 18 Apr 2008 13:27:29 -0700 > > Subject: ACPI: check a return value correctly in acpi_power_get_context() > > > > We should check *resource != NULL rather than resource != NULL, which will be > > always true. > > > > Signed-off-by: Li Zefan > > Acked-by: Zhao Yakui > > Signed-off-by: Andrew Morton > > Signed-off-by: Len Brown > > --- > > drivers/acpi/power.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c > > index 76bf6d9..f2a76ac 100644 > > --- a/drivers/acpi/power.c > > +++ b/drivers/acpi/power.c > > @@ -121,7 +121,7 @@ acpi_power_get_context(acpi_handle handle, > > } > > > > *resource = acpi_driver_data(device); > > - if (!resource) > > + if (!*resource) > > return -ENODEV; > > > > return 0; > > -- > > 1.5.3.8 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/