From: Venki Pallipadi <venkatesh.pallipadi@intel.com>
To: Rufus & Azrael <rufus-azrael@numericable.fr>
Cc: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Ingo Molnar <mingo@elte.hu>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [2.6.25-git18 => 2.6.26-rc1-git1] Xorg crash with xf86MapVidMem error
Date: Thu, 8 May 2008 14:37:22 -0700 [thread overview]
Message-ID: <20080508213722.GA28372@linux-os.sc.intel.com> (raw)
In-Reply-To: <48235DA1.5060809@numericable.fr>
On Thu, May 08, 2008 at 01:08:01PM -0700, Rufus & Azrael wrote:
> Venki Pallipadi a ecrit :
> >
> > Use UC_MINUS in reserve_memtype call with -1, when MTRR lookup fails for
> any
> > reason.
> >
> > Change the logic in mtrr_type_lookup to just get the type from the start
> > address. Using start and end adddress is not right/complete as start and
> > end can be covered by different mtrr (where old code will fail) or
> > start and end can be in same mtrr, but still have some different
> > memory type region in between. Using only start is less restrictive and
> > deterministic.
> >
> > Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> >
> > ---
> > arch/x86/kernel/cpu/mtrr/generic.c | 7 ++-----
> > arch/x86/mm/pat.c | 8 +-------
> > 2 files changed, 3 insertions(+), 12 deletions(-)
> >
>
> Hi Venki,
>
> Patch applied on 2.6.26-rc1-git5 and all works fine in X server with
> CONFIG_X86_PAT=y.
>
> See dmesg and mtrr files attached.
>
Thanks for reporting the problem and testing the fix.
ingo/thomas/hpa: Can you please pick up this patch. Fixes the PAT regression
reported on this thread.
Thanks,
Venki
next prev parent reply other threads:[~2008-05-08 21:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 8:24 [2.6.25-git18 => 2.6.26-rc1-git1] Xorg crash with xf86MapVidMem error Rufus & Azrael
2008-05-04 8:52 ` Ingo Molnar
2008-05-04 9:03 ` Rufus & Azrael
2008-05-05 17:26 ` Suresh Siddha
2008-05-05 22:19 ` Rufus & Azrael
2008-05-05 23:25 ` Venki Pallipadi
2008-05-05 23:49 ` Ingo Molnar
2008-05-06 2:09 ` Venki Pallipadi
2008-05-06 11:55 ` Ingo Molnar
[not found] ` <4820962B.6050702@numericable.fr>
2008-05-06 20:34 ` Pallipadi, Venkatesh
2008-05-06 21:56 ` Rufus & Azrael
2008-05-06 22:05 ` Pallipadi, Venkatesh
2008-05-07 20:58 ` Rufus & Azrael
2008-05-07 22:12 ` Pallipadi, Venkatesh
2008-05-08 7:08 ` Rufus & Azrael
2008-05-08 13:18 ` Pallipadi, Venkatesh
[not found] ` <B5B0CFF685D7DF46A05CF1678CFB42ED20E04609@orsmsx423.amr.corp.intel.com>
2008-05-08 19:25 ` Venki Pallipadi
2008-05-08 20:08 ` Rufus & Azrael
2008-05-08 21:37 ` Venki Pallipadi [this message]
2008-05-08 21:42 ` H. Peter Anvin
[not found] ` <20080508215931.GA5035@jamoon.sc.intel.com>
2008-05-08 23:40 ` Venki Pallipadi
2008-05-08 23:54 ` H. Peter Anvin
2008-05-09 0:34 ` Venki Pallipadi
2008-05-09 0:49 ` H. Peter Anvin
2008-05-09 0:52 ` H. Peter Anvin
2008-05-09 13:46 ` Pallipadi, Venkatesh
2008-05-29 19:01 ` Venki Pallipadi
2008-05-29 21:51 ` Rufus & Azrael
2008-05-31 8:10 ` Ingo Molnar
2008-05-06 22:51 ` Venki Pallipadi
2008-05-07 7:06 ` Ingo Molnar
2008-05-07 21:42 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508213722.GA28372@linux-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rufus-azrael@numericable.fr \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox