Re: [PATCH] Silence 'ignoring return value' warnings in drivers/video/aty/radeon_base.c

[Greg KH <greg@kroah.com>]

On Thu, May 08, 2008 at 10:36:21AM +0200, Cornelia Huck wrote:
> On Thu, 08 May 2008 17:49:44 +1000,
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
> > 
> > On Thu, 2008-05-08 at 09:34 +0200, Cornelia Huck wrote:
> > > 
> > > I was under the impression that failing the initialization was usually
> > > the right thing to do, since we end up with an un-configurable,
> > > un-usable device. But that may be coloured by my experience with s390
> > > devices, where we rely on sysfs attributes extensively. If indeed most
> > > sysfs files are non-vital, removing the __must_check and relying on a
> > > scary warning in the core may be fine. (OTOH, adding checks to the
> > > core
> > > has helped us to find some lurking bugs.)
> > 
> > The driver can still fail initialization if it wants... I'm just
> > objecting to the __must_check.
> 
> I hear you :) I found it useful, but it seems we should get rid of it
> for _create_file() now.

Why?  You point out it found some real bugs, should we just assume that
no new bugs of this same problem will happen again in the future?

thanks,

greg k-h