public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: WANG Cong <xiyou.wangcong@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
	toralf.foerster@gmx.de, James.Bottomley@hansenpartnership.com,
	linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mike Travis <travis@sgi.com>
Subject: Re: build issue #380 for v2.6.26-rc1-279-g28a4acb : mach-voyager: multiple definition of `phys_cpu_present_map'
Date: Fri, 9 May 2008 18:09:44 +0800	[thread overview]
Message-ID: <20080509100944.GK2543@hacking> (raw)
In-Reply-To: <20080509095837.GB19617@elte.hu>

On Fri, May 09, 2008 at 11:58:37AM +0200, Ingo Molnar wrote:
>
>
>i've got the one below queued up but it's stalled as it could easily be 
>wrong and there's no ack from James yet and there's been discussion back 
>and forth. James, what do you suggest?
>

Well, 'phys_cpu_present_map' of arch/x86/mach-voyager/voyager_smp.c is
only used in arch/x86/mach-voyager/voyager_smp.c, other files under
arch/x86/mach-voyager/ not.

And there's also a global 'phys_cpu_present_map', and is widely used
by files under arch/x86/kernel/.

I check these two 'phys_cpu_present_map''s types, the one used by
arch/x86/kernel/ files is not the one defined in
arch/x86/mach-voyager/voyager_smp.c. So
'arch/x86/mach-voyager/voyager_smp.c::phys_cpu_present_map' should become
static.

Thanks.


  reply	other threads:[~2008-05-09 10:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09  9:13 build issue #380 for v2.6.26-rc1-279-g28a4acb : mach-voyager: multiple definition of `phys_cpu_present_map' Toralf Förster
2008-05-09  9:30 ` WANG Cong
2008-05-09  9:58   ` Toralf Förster
2008-05-09 10:16     ` WANG Cong
2008-05-09  9:52 ` WANG Cong
2008-05-09  9:58   ` Ingo Molnar
2008-05-09 10:09     ` WANG Cong [this message]
2008-05-09 10:59     ` Toralf Förster
2008-05-09 11:22       ` WANG Cong
2008-05-09 14:22     ` James Bottomley
2008-05-09 14:47       ` Ingo Molnar
2008-05-09 15:01         ` Alexey Starikovskiy
2008-05-10 13:17         ` Ingo Molnar
2008-05-10 14:01           ` James Bottomley
2008-05-10 14:21             ` James Bottomley
2008-05-10 14:34             ` WANG Cong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080509100944.GK2543@hacking \
    --to=xiyou.wangcong@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=toralf.foerster@gmx.de \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox