[PATCH] m32r: use generic sys_pipe

[PATCH] m32r: use generic sys_pipe

[Christoph Hellwig]

m32r can use the generic sys_pipe implementation.

The current sys_pipe implementation on m32r only differes from the
generic one by passing a lot of additional unused registers to sys_pipe.

Reviewed and tested by Hirokazu Takata.

Index: linux-2.6/arch/m32r/kernel/sys_m32r.c
===================================================================
--- linux-2.6.orig/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:10.000000000 +0200
+++ linux-2.6/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:16.000000000 +0200
@@ -76,29 +76,6 @@ asmlinkage int sys_tas(int __user *addr)
 	return oldval;
 }
 
-/*
- * sys_pipe() is the normal C calling standard for creating
- * a pipe. It's not the way Unix traditionally does this, though.
- */
-asmlinkage int
-sys_pipe(unsigned long r0, unsigned long r1, unsigned long r2,
-	unsigned long r3, unsigned long r4, unsigned long r5,
-	unsigned long r6, struct pt_regs regs)
-{
-	int fd[2];
-	int error;
-
-	error = do_pipe(fd);
-	if (!error) {
-		if (copy_to_user((void __user *)r0, fd, 2*sizeof(int))) {
-			sys_close(fd[0]);
-			sys_close(fd[1]);
-			error = -EFAULT;
-		}
-	}
-	return error;
-}
-
 asmlinkage long sys_mmap2(unsigned long addr, unsigned long len,
 	unsigned long prot, unsigned long flags,
 	unsigned long fd, unsigned long pgoff)

Re: [PATCH] m32r: use generic sys_pipe

[Hirokazu Takata]

Hi, Christoph,

Please sign off this patch.

Thanks,

From: Christoph Hellwig <hch@lst.de>
Subject: [PATCH] m32r: use generic sys_pipe
Date: Fri, 09 May 2008 14:44:02 +0200
> m32r can use the generic sys_pipe implementation.
> 
> The current sys_pipe implementation on m32r only differes from the
> generic one by passing a lot of additional unused registers to sys_pipe.
> 
> Reviewed and tested by Hirokazu Takata.

Signed-off-by: Hirokazu Takata <takata@linux-m32r.org>

> Index: linux-2.6/arch/m32r/kernel/sys_m32r.c
> ===================================================================
> --- linux-2.6.orig/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:10.000000000 +0200
> +++ linux-2.6/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:16.000000000 +0200
> @@ -76,29 +76,6 @@ asmlinkage int sys_tas(int __user *addr)
>  	return oldval;
>  }
>  
> -/*
> - * sys_pipe() is the normal C calling standard for creating
> - * a pipe. It's not the way Unix traditionally does this, though.
> - */
> -asmlinkage int
> -sys_pipe(unsigned long r0, unsigned long r1, unsigned long r2,
> -	unsigned long r3, unsigned long r4, unsigned long r5,
> -	unsigned long r6, struct pt_regs regs)
> -{
> -	int fd[2];
> -	int error;
> -
> -	error = do_pipe(fd);
> -	if (!error) {
> -		if (copy_to_user((void __user *)r0, fd, 2*sizeof(int))) {
> -			sys_close(fd[0]);
> -			sys_close(fd[1]);
> -			error = -EFAULT;
> -		}
> -	}
> -	return error;
> -}
> -
>  asmlinkage long sys_mmap2(unsigned long addr, unsigned long len,
>  	unsigned long prot, unsigned long flags,
>  	unsigned long fd, unsigned long pgoff)
> 

Re: [PATCH] m32r: use generic sys_pipe

[Christoph Hellwig]

On Fri, May 09, 2008 at 10:37:51PM +0900, Hirokazu Takata wrote:
> Hi, Christoph,
> 
> Please sign off this patch.

Sorry, looks like it got lost before I sent it.

> > Reviewed and tested by Hirokazu Takata.
> 
> Signed-off-by: Hirokazu Takata <takata@linux-m32r.org>


Signed-off-by: Christoph Hellwig <hch@lst.de>

> 
> > Index: linux-2.6/arch/m32r/kernel/sys_m32r.c
> > ===================================================================
> > --- linux-2.6.orig/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:10.000000000 +0200
> > +++ linux-2.6/arch/m32r/kernel/sys_m32r.c	2008-05-09 12:44:16.000000000 +0200
> > @@ -76,29 +76,6 @@ asmlinkage int sys_tas(int __user *addr)
> >  	return oldval;
> >  }
> >  
> > -/*
> > - * sys_pipe() is the normal C calling standard for creating
> > - * a pipe. It's not the way Unix traditionally does this, though.
> > - */
> > -asmlinkage int
> > -sys_pipe(unsigned long r0, unsigned long r1, unsigned long r2,
> > -	unsigned long r3, unsigned long r4, unsigned long r5,
> > -	unsigned long r6, struct pt_regs regs)
> > -{
> > -	int fd[2];
> > -	int error;
> > -
> > -	error = do_pipe(fd);
> > -	if (!error) {
> > -		if (copy_to_user((void __user *)r0, fd, 2*sizeof(int))) {
> > -			sys_close(fd[0]);
> > -			sys_close(fd[1]);
> > -			error = -EFAULT;
> > -		}
> > -	}
> > -	return error;
> > -}
> > -
> >  asmlinkage long sys_mmap2(unsigned long addr, unsigned long len,
> >  	unsigned long prot, unsigned long flags,
> >  	unsigned long fd, unsigned long pgoff)
> > 
---end quoted text---