From: Eric Sesterhenn <snakebyte@gmx.de>
To: Andy Whitcroft <apw@shadowen.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, zippel@linux-m68k.org
Subject: Re: [Patch] hfsplus oops on image without extends
Date: Fri, 9 May 2008 16:26:26 +0200 [thread overview]
Message-ID: <20080509142626.GA20287@alice> (raw)
In-Reply-To: <20080509131326.GA31089@shadowen.org>
* Andy Whitcroft (apw@shadowen.org) wrote:
> On Wed, May 07, 2008 at 12:42:44PM +0200, Eric Sesterhenn wrote:
> > hi,
> >
> > the following patch fixes an oops with a corrupted hfs+ image.
> > see http://bugzilla.kernel.org/show_bug.cgi?id=10548 for details.
> >
> > Problem is that we call hfs_btree_open() from hfsplus_fill_super() to set
> > HFSPLUS_SB(sb).[ext_tree|cat_tree]
> > Both trees are still NULL at this moment. If hfs_btree_open() fails for
> > any reason it calls iput() on the page, which
> > gets to hfsplus_releasepage() which tries to access HFSPLUS_SB(sb).*
> > which is still NULL and oopses while dereferencing it.
>
> Erm, I presume this is meant to be 'if', checkpatch whined about the
> space as it thought it was a function. I guess this hasn't been compile
> tested?
sorry, i messed this up, didnt have the original patch anymore and
quickly recreated it. Andrew already put a fix in -mm
Greetings, Eric
prev parent reply other threads:[~2008-05-09 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 10:42 [Patch] hfsplus oops on image without extends Eric Sesterhenn
2008-05-09 13:13 ` Andy Whitcroft
2008-05-09 14:26 ` Eric Sesterhenn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080509142626.GA20287@alice \
--to=snakebyte@gmx.de \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox