Re: [Patch 7/9] fs/exec.c: fix wrong return value of prepare_binprm()

Al Viro
2008-05-10T19:31:20Z

On Thu, May 08, 2008 at 09:52:32PM +0800, WANG Cong wrote:
> All prepare_binprm()'s callers assume that prepare_binprm() fails
> when it returns negative. However, prepare_binprm() most probably returns
> the return value of kernel_read(), which may return positive on failure!
>
> Thus this should be fixed.

Since when does read return positive on failure?