Re: [Patch 9/9] fs/exec.c: fix a wrong goto path

WANG Cong
2008-05-12T03:54:03Z

On Sat, May 10, 2008 at 08:37:01PM +0100, Al Viro wrote:
>On Thu, May 08, 2008 at 09:52:34PM +0800, WANG Cong wrote:
>> When nameidata_to_filp() fails, I see no reasons to fall into 'out' path
>> where doesn't free any resources at all.
>
>How about "nameidata_to_filp() frees on failure"?

When it fails, it should free the resources that were allocated before it.
That's to say, it should goto 'exit' on failure.

Am I missing something obvious?

--
Hi, I'm a .signature virus, please copy/paste me to help me spread
all over the world.