Re: [Patch 7/9] fs/exec.c: fix wrong return value of prepare_binprm()

WANG Cong
2008-05-12T04:54:51Z

On Mon, May 12, 2008 at 05:37:58AM +0100, Al Viro wrote:
>It returns positives *exactly* on success. In the case you've quoted
>we don't have any problems with read; we do have a problem with _short_
>read (i.e. miscalculated field size or truncated binary). In the case
>you've patched we _expect_ a short read; it's normal for short scripts,
>to start with. And we are ready to deal with it - the buffer is prefilled
>with zeroes and either we have enough to recognize signature (in which case
>we'll find the binfmt handler and let it deal with the entire thing, with
>full checks of its own) or we will not, in which case nobody will recognize
>the damn thing and that's it.

Thanks for your detailed explanation.

Since it's expected, it's needless to fix it. :-)

--
Hi, I'm a .signature virus, please copy/paste me to help me spread
all over the world.