Re: [Patch 5/9] fs/binfmt_em86.c: fix resource leaks

WANG Cong
2008-05-12T03:55:53Z

On Sat, May 10, 2008 at 08:25:09PM +0100, Al Viro wrote:
>On Thu, May 08, 2008 at 09:52:30PM +0800, WANG Cong wrote:
>> ->load_binary()'s caller only frees resources which ->load_binary() applied
>> when it succeeded, so ->load_binary() itself should free the resources on
>> failure.
>
>No, it should not. do_execve() will free them just fine.

Oh, yes. I missed this. So 4,5,6 should be dropped.

Thanks!

--
Hi, I'm a .signature virus, please copy/paste me to help me spread
all over the world.