Re: [PATCH] x86: enable hpet=force for AMD SB400

[Alistair John Strachan <alistair@devzero.co.uk>]

On Saturday 10 May 2008 00:55:01 Andrew Morton wrote:
> On Sat, 10 May 2008 01:42:30 +0200 (CEST)
>
> Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Fri, 9 May 2008, Andrew Morton wrote:
> > > On Fri, 9 May 2008 11:49:11 +0200
> > >
> > > Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> > > > x86: enable hpet=force for ATI SB400
> > >
> > > Sigh.
> > >
> > > > Add quirk to allow forced usage of HPET on ATI SB400.
> > > > I stumbled over machines where HPET is enabled but not reported
> > > > by BIOS.
> > >
> > > Is there no way in which we can probe for or identify this condition,
> > > rather than hoping that the user will find out about this boot option?
> >
> > I'd love to have a sane solution for that, but looking at the rate of
> > HPET wreckage since we increased the usage of HPET I'm happy to have
> > this as an opt in thingy.
>
> Well we don't have to auto-enable the hpet.  Simply adding a loud "you
> should try the hpet=force option" printk would help a lot of people.

I'm a bit confused about the policy here: if we look at the Intel chipset 
overrides for HPET, they conditionally enable the HPET _without_ the 
hpet=force option if you have a chipset on the whitelist.

If Intel can do this on their chipsets, why is this not being done for the ATI 
chipsets for which (presumably) AMD have specs?

One thing I'd considered was that HPET isn't actually used very often on Intel 
chipsets because on most recent Intel CPUs the TSC is stable, but I think 
either the Intel quirk should be consistent with the hpet=force usage, 
or "known correct" HPET overrides should just always be applied.

-- 
Cheers,
Alistair.

137/1 Warrender Park Road, Edinburgh, UK.