[PATCH] isdn/capi: return proper errnos on module init

[PATCH] isdn/capi: return proper errnos on module init

[Karsten Keil]

cdebug_init is called from kcapi_init which is module initialization function,
so it must return negative values on errors

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Acked-by: Karsten Keil <kkeil@suse.de>
---
compile tested only
---
 drivers/isdn/capi/capiutil.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/isdn/capi/capiutil.c b/drivers/isdn/capi/capiutil.c
--- a/drivers/isdn/capi/capiutil.c
+++ b/drivers/isdn/capi/capiutil.c
@@ -948,17 +948,17 @@ int __init cdebug_init(void)
 {
 	g_cmsg= kmalloc(sizeof(_cmsg), GFP_KERNEL);
 	if (!g_cmsg)
-		return ENOMEM;
+		return -ENOMEM;
 	g_debbuf = kmalloc(sizeof(_cdebbuf), GFP_KERNEL);
 	if (!g_debbuf) {
 		kfree(g_cmsg);
-		return ENOMEM;
+		return -ENOMEM;
 	}
 	g_debbuf->buf = kmalloc(CDEBUG_GSIZE, GFP_KERNEL);
 	if (!g_debbuf->buf) {
 		kfree(g_cmsg);
 		kfree(g_debbuf);
-		return ENOMEM;;
+		return -ENOMEM;;
 	}
 	g_debbuf->size = CDEBUG_GSIZE;
 	g_debbuf->buf[0] = 0;
-- 

Re: [PATCH] isdn/capi: return proper errnos on module init

[Sam Ravnborg]

On Sun, May 11, 2008 at 11:07:07PM +0200, Karsten Keil wrote:
> cdebug_init is called from kcapi_init which is module initialization function,
> so it must return negative values on errors
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Acked-by: Karsten Keil <kkeil@suse.de>

Hi Karsten.

Lately David Miller has started to include isdn patches
in his netdev tree. So I think you should pass then on to David
and not Andrew.
David or Andrew will correct me if I'm wrong...

	Sam

> ---
> compile tested only
> ---
>  drivers/isdn/capi/capiutil.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/isdn/capi/capiutil.c b/drivers/isdn/capi/capiutil.c
> --- a/drivers/isdn/capi/capiutil.c
> +++ b/drivers/isdn/capi/capiutil.c
> @@ -948,17 +948,17 @@ int __init cdebug_init(void)
>  {
>  	g_cmsg= kmalloc(sizeof(_cmsg), GFP_KERNEL);
>  	if (!g_cmsg)
> -		return ENOMEM;
> +		return -ENOMEM;
>  	g_debbuf = kmalloc(sizeof(_cdebbuf), GFP_KERNEL);
>  	if (!g_debbuf) {
>  		kfree(g_cmsg);
> -		return ENOMEM;
> +		return -ENOMEM;
>  	}
>  	g_debbuf->buf = kmalloc(CDEBUG_GSIZE, GFP_KERNEL);
>  	if (!g_debbuf->buf) {
>  		kfree(g_cmsg);
>  		kfree(g_debbuf);
> -		return ENOMEM;;
> +		return -ENOMEM;;
>  	}
>  	g_debbuf->size = CDEBUG_GSIZE;
>  	g_debbuf->buf[0] = 0;
> -- 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] isdn/capi: return proper errnos on module init

[Andrew Morton]

On Sun, 11 May 2008 23:21:17 +0200 Sam Ravnborg <sam@ravnborg.org> wrote:

> On Sun, May 11, 2008 at 11:07:07PM +0200, Karsten Keil wrote:
> > cdebug_init is called from kcapi_init which is module initialization function,
> > so it must return negative values on errors
> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> > Acked-by: Karsten Keil <kkeil@suse.de>
> 
> Hi Karsten.
> 
> Lately David Miller has started to include isdn patches
> in his netdev tree. So I think you should pass then on to David
> and not Andrew.
> David or Andrew will correct me if I'm wrong...

That's news to me, but I'm easy either way.  Another set of eyes never
hurts.  Dave: your call, please.

Re: [PATCH] isdn/capi: return proper errnos on module init

[David Miller]

From: Sam Ravnborg <sam@ravnborg.org>
Date: Sun, 11 May 2008 23:21:17 +0200

> Lately David Miller has started to include isdn patches
> in his netdev tree. So I think you should pass then on to David
> and not Andrew.
> David or Andrew will correct me if I'm wrong...

Yes, I try to pick them up.

[PATCH] isdn/capi: return proper errnos on module init

[Marcin Slusarz]

cdebug_init is called from kcapi_init which is module initialization function,
so it must return negative values on errors

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Karsten Keil <kkeil@suse.de>
---
compile tested only
---
 drivers/isdn/capi/capiutil.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/isdn/capi/capiutil.c b/drivers/isdn/capi/capiutil.c
--- a/drivers/isdn/capi/capiutil.c
+++ b/drivers/isdn/capi/capiutil.c
@@ -948,17 +948,17 @@ int __init cdebug_init(void)
 {
 	g_cmsg= kmalloc(sizeof(_cmsg), GFP_KERNEL);
 	if (!g_cmsg)
-		return ENOMEM;
+		return -ENOMEM;
 	g_debbuf = kmalloc(sizeof(_cdebbuf), GFP_KERNEL);
 	if (!g_debbuf) {
 		kfree(g_cmsg);
-		return ENOMEM;
+		return -ENOMEM;
 	}
 	g_debbuf->buf = kmalloc(CDEBUG_GSIZE, GFP_KERNEL);
 	if (!g_debbuf->buf) {
 		kfree(g_cmsg);
 		kfree(g_debbuf);
-		return ENOMEM;;
+		return -ENOMEM;;
 	}
 	g_debbuf->size = CDEBUG_GSIZE;
 	g_debbuf->buf[0] = 0;
--