* [RFC] [PATCH] s390/net/claw: don't ignore return value of find_link
@ 2008-05-11 19:57 Marcin Slusarz
0 siblings, 0 replies; only message in thread
From: Marcin Slusarz @ 2008-05-11 19:57 UTC (permalink / raw)
To: LKML; +Cc: Martin Schwidefsky
find_link checked some conditions but then ignored it - fix it.
return negative error for consistency with the rest of kernel
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
please check if it's correct patch
---
drivers/s390/net/claw.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/net/claw.c b/drivers/s390/net/claw.c
--- a/drivers/s390/net/claw.c
+++ b/drivers/s390/net/claw.c
@@ -1722,18 +1722,18 @@ find_link(struct net_device *dev, char *host_name, char *ws_name )
case PACKING_ASK:
if ((memcmp(WS_APPL_NAME_PACKED, host_name, 8)!=0) ||
(memcmp(WS_APPL_NAME_PACKED, ws_name, 8)!=0 ))
- rc = EINVAL;
+ rc = -EINVAL;
break;
case DO_PACKED:
case PACK_SEND:
if ((memcmp(WS_APPL_NAME_IP_NAME, host_name, 8)!=0) ||
(memcmp(WS_APPL_NAME_IP_NAME, ws_name, 8)!=0 ))
- rc = EINVAL;
+ rc = -EINVAL;
break;
default:
if ((memcmp(HOST_APPL_NAME, host_name, 8)!=0) ||
(memcmp(p_env->api_type , ws_name, 8)!=0))
- rc = EINVAL;
+ rc = -EINVAL;
break;
}
@@ -1741,7 +1741,7 @@ find_link(struct net_device *dev, char *host_name, char *ws_name )
printk(KERN_INFO "%s:%s Exit on line %d\n",
dev->name,__func__,__LINE__);
#endif
- return 0;
+ return rc;
} /* end of find_link */
/*-------------------------------------------------------------------*
--
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-05-11 19:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-11 19:57 [RFC] [PATCH] s390/net/claw: don't ignore return value of find_link Marcin Slusarz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox