[PATCH] jfs: 0 is not valid errno value

[PATCH] jfs: 0 is not valid errno value

[Marcin Slusarz]

... so return NULL from jfs_lookup

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Dave Kleikamp <shaggy@austin.ibm.com>
Cc: jfs-discussion@lists.sourceforge.net
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
---
is it ok to return NULL from this function?
compile tested only
---
 fs/jfs/namei.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c
--- a/fs/jfs/namei.c
+++ b/fs/jfs/namei.c
@@ -1455,7 +1455,7 @@ static struct dentry *jfs_lookup(struct inode *dip, struct dentry *dentry, struc
 		free_UCSname(&key);
 		if (rc == -ENOENT) {
 			d_add(dentry, NULL);
-			return ERR_PTR(0);
+			return NULL;
 		} else if (rc) {
 			jfs_err("jfs_lookup: dtSearch returned %d", rc);
 			return ERR_PTR(rc);
-- 

Re: [PATCH] jfs: 0 is not valid errno value

[Dave Kleikamp]

On Sun, 2008-05-11 at 22:08 +0200, Marcin Slusarz wrote:
> ... so return NULL from jfs_lookup
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>

Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>

> Cc: jfs-discussion@lists.sourceforge.net
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> ---
> is it ok to return NULL from this function?
> compile tested only

Yeah.  I'm not sure how ERR_PTR(0) got in there in the first place.
It's been that way for quite a while.

I'll add it to the jfs git tree.

Thanks,
Shaggy

> ---
>  fs/jfs/namei.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c
> --- a/fs/jfs/namei.c
> +++ b/fs/jfs/namei.c
> @@ -1455,7 +1455,7 @@ static struct dentry *jfs_lookup(struct inode *dip, struct dentry *dentry, struc
>  		free_UCSname(&key);
>  		if (rc == -ENOENT) {
>  			d_add(dentry, NULL);
> -			return ERR_PTR(0);
> +			return NULL;
>  		} else if (rc) {
>  			jfs_err("jfs_lookup: dtSearch returned %d", rc);
>  			return ERR_PTR(rc);
-- 
David Kleikamp
IBM Linux Technology Center