Re: 2.6.26-rc1 on x86: ld: warning: dot moved backwards before `.text'

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Sunday, 11 of May 2008, Cyrill Gorcunov wrote:
> [H. Peter Anvin - Sun, May 11, 2008 at 11:25:54AM -0700]
> > Cyrill Gorcunov wrote:
> >> Hi Peter,
> >> actually I only doubt about exactly position of this headers - I mean
> >> meguess it better should be _before_ "_end" not after. Since the others
> >> script uses (acpi/wakeup_rm.S):
> >> 	wakeup_code_start:
> >> 	.incbin	"arch/x86/kernel/acpi/realmode/wakeup.bin"
> >> 	wakeup_code_end:
> >> and kernel uses these wakeup_code_* marks to save/restore memory I think
> >> it should be like
> >> 	. = HEADER_OFFSET;
> >> 	.header : {
> >> 		...
> >> 	}
> >> 	. = ALIGN(16);
> >> 	_end = .;
> >> 	/DISCARD/ ...
> >
> > Yes, I believe that's correct.
> >
> > 	-hpa
> >
> 
> Thanks for review, Peter, I'll cook a patch and wait for
> Pavel's opinion ;-)

I've tested the appended one.  If that's what you mean, we'll ask Ingo to take
it.

Thanks,
Rafael


---
 arch/x86/kernel/acpi/realmode/wakeup.lds.S |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-2.6/arch/x86/kernel/acpi/realmode/wakeup.lds.S
===================================================================
--- linux-2.6.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S
+++ linux-2.6/arch/x86/kernel/acpi/realmode/wakeup.lds.S
@@ -12,11 +12,6 @@ ENTRY(_start)
 
 SECTIONS
 {
-	. = HEADER_OFFSET;
-	.header : {
-		 *(.header)
-	}
-
 	. = 0;
 	.text : {
 		 *(.text*)
@@ -50,6 +45,11 @@ SECTIONS
 		__bss_end = .;
 	}
 
+	. = HEADER_OFFSET;
+	.header : {
+		 *(.header)
+	}
+
 	. = ALIGN(16);
 	_end = .;