From: David Miller <davem@davemloft.net>
To: Graf.Yang@analog.com
Cc: marcel@holtmann.org, cooloney@kernel.org, samuel@sortiz.org,
irda-users@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [net/irda]: Fix a misalign access issue.
Date: Mon, 12 May 2008 21:14:02 -0700 (PDT) [thread overview]
Message-ID: <20080512.211402.33040026.davem@davemloft.net> (raw)
In-Reply-To: <0F1B54C89D5F954D8535DB252AF412FA0164BC89@chinexm1.ad.analog.com>
From: "Yang, Graf" <Graf.Yang@analog.com>
Date: Tue, 13 May 2008 12:07:35 +0800
> I have tried
> struct irda_device_info {
> __u32 saddr; /* Address of local interface */
> __u32 daddr; /* Address of remote device */
> char info[22]; /* Description */
> __u8 charset; /* Charset used for description */
> __u8 reserve; /* For align data */
> __u8 hints[2]; /* Hint bits */
> };
>
> It works with my irda driver. Can I modify it like this?
This header file and the irda_device_info datastructure are exported
to, and used by, userspace.
Therefore you cannot change this structure's layout without breaking
every single existing IRDA binary out there.
next prev parent reply other threads:[~2008-05-13 4:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 10:35 [PATCH 1/1] [net/irda]: Fix a misalign access issue Bryan Wu
2008-05-12 13:15 ` Marcel Holtmann
2008-05-13 4:07 ` Yang, Graf
2008-05-13 4:14 ` David Miller [this message]
2008-05-13 6:07 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512.211402.33040026.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Graf.Yang@analog.com \
--cc=cooloney@kernel.org \
--cc=irda-users@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox