From: David Brownell <david-b@pacbell.net>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org
Subject: Re: drivers/usb/misc/usbtest.c weirdness
Date: Mon, 12 May 2008 01:02:22 -0700 [thread overview]
Message-ID: <200805120102.23320.david-b@pacbell.net> (raw)
In-Reply-To: <20080511202222.GP19058@joi>
On Sunday 11 May 2008, Marcin Slusarz wrote:
>
> test_ctrl_queue expects (?) positive and negative errnos.
> what is going on here?
The sign is just a way to flag something:
/* some faults are allowed, not required */
The negative ones are required. Positive codes are optional,
in the sense that, depending on how the peripheral happens
to be implemented, they won't necessarily be triggered.
For example, the test to fetch a device qualifier desriptor
must succeed if the device is running at high speed. So that
test is marked as negative. But when it's full speed, it
could legitimately fail; marked as positive. And so on for
other tests.
Look at how the codes are *interpreted* to see it work.
next prev parent reply other threads:[~2008-05-12 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 20:22 drivers/usb/misc/usbtest.c weirdness Marcin Slusarz
2008-05-12 8:02 ` David Brownell [this message]
2008-05-12 18:17 ` [PATCH] usb/usbtest: comment on why this code "expects" negative and positive errnos Marcin Slusarz
2008-05-13 22:07 ` patch usbtest-comment-on-why-this-code-expects-negative-and-positive-errnos.patch added to gregkh-2.6 tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805120102.23320.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox