From: "J. Bruce Fields" <bfields@fieldses.org>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Tom Tucker <tom@opengridcomputing.com>
Subject: Re: [PATCH] net/sunrpc/xprtrdma: fix svc_rdma_create out of memory error path
Date: Sun, 11 May 2008 21:20:22 -0400 [thread overview]
Message-ID: <20080512012022.GA27353@fieldses.org> (raw)
In-Reply-To: <20080511200719.GM19058@joi>
Thanks! But I think Tom is just doing some final revisions on a patch
series that already includes this fix?
--b.
On Sun, May 11, 2008 at 10:07:25PM +0200, Marcin Slusarz wrote:
> ERR_PTR takes negative errno as a parameter
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Tom Tucker <tom@opengridcomputing.com>
> Cc: J. Bruce Fields <bfields@citi.umich.edu>
> ---
> compile tested only
> ---
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -661,7 +661,7 @@ static struct svc_xprt *svc_rdma_create(struct svc_serv *serv,
>
> cma_xprt = rdma_create_xprt(serv, 1);
> if (!cma_xprt)
> - return ERR_PTR(ENOMEM);
> + return ERR_PTR(-ENOMEM);
> xprt = &cma_xprt->sc_xprt;
>
> listen_id = rdma_create_id(rdma_listen_handler, cma_xprt, RDMA_PS_TCP);
> --
prev parent reply other threads:[~2008-05-12 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 20:07 [PATCH] net/sunrpc/xprtrdma: fix svc_rdma_create out of memory error path Marcin Slusarz
2008-05-12 1:20 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512012022.GA27353@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox