* [PATCH] net/sunrpc/xprtrdma: fix svc_rdma_create out of memory error path
@ 2008-05-11 20:07 Marcin Slusarz
2008-05-12 1:20 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Slusarz @ 2008-05-11 20:07 UTC (permalink / raw)
To: LKML; +Cc: Tom Tucker, J. Bruce Fields
ERR_PTR takes negative errno as a parameter
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Tom Tucker <tom@opengridcomputing.com>
Cc: J. Bruce Fields <bfields@citi.umich.edu>
---
compile tested only
---
net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -661,7 +661,7 @@ static struct svc_xprt *svc_rdma_create(struct svc_serv *serv,
cma_xprt = rdma_create_xprt(serv, 1);
if (!cma_xprt)
- return ERR_PTR(ENOMEM);
+ return ERR_PTR(-ENOMEM);
xprt = &cma_xprt->sc_xprt;
listen_id = rdma_create_id(rdma_listen_handler, cma_xprt, RDMA_PS_TCP);
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/sunrpc/xprtrdma: fix svc_rdma_create out of memory error path
2008-05-11 20:07 [PATCH] net/sunrpc/xprtrdma: fix svc_rdma_create out of memory error path Marcin Slusarz
@ 2008-05-12 1:20 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2008-05-12 1:20 UTC (permalink / raw)
To: Marcin Slusarz; +Cc: LKML, Tom Tucker
Thanks! But I think Tom is just doing some final revisions on a patch
series that already includes this fix?
--b.
On Sun, May 11, 2008 at 10:07:25PM +0200, Marcin Slusarz wrote:
> ERR_PTR takes negative errno as a parameter
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Tom Tucker <tom@opengridcomputing.com>
> Cc: J. Bruce Fields <bfields@citi.umich.edu>
> ---
> compile tested only
> ---
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -661,7 +661,7 @@ static struct svc_xprt *svc_rdma_create(struct svc_serv *serv,
>
> cma_xprt = rdma_create_xprt(serv, 1);
> if (!cma_xprt)
> - return ERR_PTR(ENOMEM);
> + return ERR_PTR(-ENOMEM);
> xprt = &cma_xprt->sc_xprt;
>
> listen_id = rdma_create_id(rdma_listen_handler, cma_xprt, RDMA_PS_TCP);
> --
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-12 1:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-11 20:07 [PATCH] net/sunrpc/xprtrdma: fix svc_rdma_create out of memory error path Marcin Slusarz
2008-05-12 1:20 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox