From: David Brownell <david-b@pacbell.net>
To: "Bryan Wu" <cooloney@kernel.org>
Cc: "Mike Frysinger" <vapier.adi@gmail.com>,
"pHilipp Zabel" <philipp.zabel@gmail.com>,
dbrownell@users.sourceforge.net, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org,
"Michael Hennerich" <michael.hennerich@analog.com>
Subject: Re: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver
Date: Mon, 12 May 2008 09:54:06 -0700 [thread overview]
Message-ID: <200805120954.06986.david-b@pacbell.net> (raw)
In-Reply-To: <386072610805120742k47e2433cxf7a1f8605fca47fb@mail.gmail.com>
On Monday 12 May 2008, Bryan Wu wrote:
> Right. I mean the generic GPIO layer in Blackfin port, not the common code.
>
> And on the other hand, maybe there are also other hardware which has similar
> issue as Blackfin. So the common GPIO layer can take care of this, how
> do you think, David?
No; it's a Blackfin-specific design flaw, one that I've not seen
in any other chip's GPIO support. So it should stay in the Blackfin
support code. (Possibly even specialized for the specific chips
which have that flaw/erratum.)
- Dave
next prev parent reply other threads:[~2008-05-12 16:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 10:17 [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver Bryan Wu
2008-05-12 11:27 ` pHilipp Zabel
2008-05-12 11:42 ` Mike Frysinger
2008-05-12 12:11 ` Bryan Wu
2008-05-12 12:47 ` Mike Frysinger
2008-05-12 14:42 ` Bryan Wu
2008-05-12 16:54 ` David Brownell [this message]
2008-05-12 16:59 ` Mike Frysinger
2008-05-13 7:53 ` Hennerich, Michael
2008-05-12 16:55 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805120954.06986.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=cooloney@kernel.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=philipp.zabel@gmail.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox