From: David Brownell <david-b@pacbell.net>
To: Bryan Wu <cooloney@kernel.org>
Cc: dbrownell@users.sourceforge.net, dmitry.torokhov@gmail.com,
philipp.zabel@gmail.com, linux-kernel@vger.kernel.org,
Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver
Date: Mon, 12 May 2008 09:55:52 -0700 [thread overview]
Message-ID: <200805120955.53380.david-b@pacbell.net> (raw)
In-Reply-To: <1210587437-9751-1-git-send-email-cooloney@kernel.org>
On Monday 12 May 2008, Bryan Wu wrote:
> unsigned int type = button->type ?: EV_KEY;
> + GPIOKEYS_EDGE_SENSE(0);
> int state = (gpio_get_value(gpio) ? 1 : 0) ^ button->active_low;
> -
> + GPIOKEYS_EDGE_SENSE(1);
By the way ... don't intersperse declarations like "int state"
with code like what those EDGE_SENSE macros wraps...
prev parent reply other threads:[~2008-05-12 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 10:17 [PATCH 1/1] [INPUT/KEYPAD] gpio keypad: Replace current blackfin specific pfbutton driver with kernel generic gpio key driver Bryan Wu
2008-05-12 11:27 ` pHilipp Zabel
2008-05-12 11:42 ` Mike Frysinger
2008-05-12 12:11 ` Bryan Wu
2008-05-12 12:47 ` Mike Frysinger
2008-05-12 14:42 ` Bryan Wu
2008-05-12 16:54 ` David Brownell
2008-05-12 16:59 ` Mike Frysinger
2008-05-13 7:53 ` Hennerich, Michael
2008-05-12 16:55 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805120955.53380.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=cooloney@kernel.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox