From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Oliver Endriss <o.endriss@gmx.de>,
Andrew de Quincey <adq_dvb@lidskialf.net>,
Johannes Stezenbach <js@linuxtv.org>
Subject: [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix
Date: Mon, 12 May 2008 12:12:31 +0200 [thread overview]
Message-ID: <20080512101231.GA11755@elte.hu> (raw)
x86.git testing found the following build failure in 2.6.26-rc2:
drivers/media/dvb/ttpci/fdump "/usr/lib/hotplug/firmware/dvb-ttpci-01.fw" dvb_ttpci_fw drivers/media/dvb/ttpci/av7110_firm.h
firmware file '/usr/lib/hotplug/firmware/dvb-ttpci-01.fw' not found
make[4]: *** [drivers/media/dvb/ttpci/av7110_firm.h] Error 255
make[3]: *** [drivers/media/dvb/ttpci] Error 2
in this config:
http://redhat.com/~mingo/misc/config-Mon_May_12_11_29_29_CEST_2008.bad
the reason for the build bug is that the driver's Kconfig ignores the
PREVENT_FIRMWARE_BUILD=y config setting and tries to build the firmware
which (like other firmware build methods) relies on a non-upstream
firmware blob. The fix is to make the firmware build depend on
!PREVENT_FIRMWARE_BUILD.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/media/dvb/ttpci/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/media/dvb/ttpci/Kconfig
===================================================================
--- linux.orig/drivers/media/dvb/ttpci/Kconfig
+++ linux/drivers/media/dvb/ttpci/Kconfig
@@ -33,7 +33,7 @@ config DVB_AV7110
config DVB_AV7110_FIRMWARE
bool "Compile AV7110 firmware into the driver"
- depends on DVB_AV7110 && !STANDALONE
+ depends on DVB_AV7110 && !STANDALONE && !PREVENT_FIRMWARE_BUILD
default y if DVB_AV7110=y
help
The AV7110 firmware is normally loaded by the firmware hotplug manager.
next reply other threads:[~2008-05-12 10:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 10:12 Ingo Molnar [this message]
2008-05-12 17:30 ` [patch, 2.6.26-rc2] dvb: drivers/media/dvb/ttpci/fdump firmware build error fix Oliver Endriss
2008-05-12 19:46 ` Johannes Stezenbach
2008-05-12 20:18 ` Oliver Endriss
2008-05-12 20:30 ` Oliver Endriss
2008-05-12 20:46 ` Johannes Stezenbach
2008-05-13 9:50 ` Ingo Molnar
2008-05-13 14:33 ` Oliver Endriss
2008-05-13 14:49 ` Ingo Molnar
2008-05-13 15:23 ` Johannes Stezenbach
[not found] ` <20080513163930.GB21678@elte.hu>
2008-05-13 16:42 ` Ingo Molnar
2008-05-13 18:18 ` Johannes Stezenbach
2008-05-13 23:49 ` Oliver Endriss
[not found] ` <20080513163647.GA21678@elte.hu>
2008-05-13 16:41 ` Ingo Molnar
2008-05-13 17:01 ` Johannes Stezenbach
2008-05-14 0:55 ` Oliver Endriss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512101231.GA11755@elte.hu \
--to=mingo@elte.hu \
--cc=adq_dvb@lidskialf.net \
--cc=js@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=o.endriss@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox