From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bryan Wu <cooloney@kernel.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Cliff Cai <cliff.cai@analog.com>, Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH 2/3] Blackfin Sports UART Driver: fix bug - the bug caused by sport overrun, use timer to flip the tty buffer in order to return from rx ISR quickly
Date: Mon, 12 May 2008 10:48:43 +0100 [thread overview]
Message-ID: <20080512104843.5b6fb486@core> (raw)
In-Reply-To: <1210565409-3655-3-git-send-email-cooloney@kernel.org>
Can you explain what the timer is for ? If you are trying to push the tty
processing out of the interrupt handler then surely schedule_work would
be sufficient. Also if you don't have tty->low_latency set the tty layer
will already do the actual processing work each timer event not in the
IRQ.
next prev parent reply other threads:[~2008-05-12 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 4:10 [PATCH 0/3] Blackfin Sports UART Driver fixing Bryan Wu
2008-05-12 4:10 ` [PATCH 1/3] Blackfin SPORTS UART Driver: converting BFIN->BLACKFIN Bryan Wu
2008-05-12 4:10 ` [PATCH 2/3] Blackfin Sports UART Driver: fix bug - the bug caused by sport overrun, use timer to flip the tty buffer in order to return from rx ISR quickly Bryan Wu
2008-05-12 9:48 ` Alan Cox [this message]
2008-05-13 6:02 ` Cai, Cliff
2008-05-12 4:10 ` [PATCH 3/3] Blackfin SPORT UART Driver: rewrite assembly with better constraints (and proper clobber lists) so gcc can do a better job Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512104843.5b6fb486@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox