From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bryan Wu <cooloney@kernel.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Javier Herrero <jherrero@hvsistemas.es>,
Bryan Wu <bryan.wu@analog.com>, Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board
Date: Mon, 12 May 2008 10:54:15 +0100 [thread overview]
Message-ID: <20080512105415.6a8fb88c@core> (raw)
In-Reply-To: <1210566565-6205-2-git-send-email-cooloney@kernel.org>
>
> +#ifdef SERIAL_EXTRA_IRQ_FLAGS
> + irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
> +#endif
> +
We try and keep ifdefs out of code. It is also not clear what you would
do if you had a box where the extra flags depended on the port.
So two suggestions
Either
Add just the line
+ irq_flags |= SERIAL_EXTRA_IRQ_FLAGS;
and at the end of 8250.h do
#ifndef SERIAL_EXTRA_IRQ_FLAGS
#define SERIAL_EXTRA_IRQ_FLAGS 0
#endif
or the same but with an argument (unused for now)
SERIAL_EXTRA_IRQ_FLAGS(up)
Alan
next prev parent reply other threads:[~2008-05-12 10:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 4:29 [PATCH 0/2] Try to make 8250 serial work on embedded platform Bryan Wu
2008-05-12 4:29 ` [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board Bryan Wu
2008-05-12 9:54 ` Alan Cox [this message]
2008-05-12 17:31 ` Javier Herrero
2008-05-12 4:29 ` [PATCH 2/2] [Blackfin] serial driver: add extra IRQ flag for 8250 serial driver Bryan Wu
-- strict thread matches above, loose matches on Subject: below --
2008-05-13 4:14 [PATCH 0/2] Add irq extra flags to " Bryan Wu
2008-05-13 4:14 ` [PATCH 1/2] [8250 Serial Driver]: Added support for 8250-class UARTs in HV Sistemas H8606 board Bryan Wu
2008-05-13 9:50 ` Alan Cox
2008-05-13 10:23 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080512105415.6a8fb88c@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=cooloney@kernel.org \
--cc=jherrero@hvsistemas.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox