public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Bryan Wu <cooloney@kernel.org>
Cc: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org,
	Michael Hennerich <michael.hennerich@analog.com>
Subject: Re: [PATCH 1/1] [PCMCIA]: add support the CF PCMCIA driver for Blackfin
Date: Mon, 12 May 2008 12:37:26 +0100	[thread overview]
Message-ID: <20080512113726.GB15305@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1210589200-12431-1-git-send-email-cooloney@kernel.org>

On Mon, May 12, 2008 at 06:46:40PM +0800, Bryan Wu wrote:
> +static struct device_driver bfin_cf_driver = {
> +	.name		= (char *) driver_name,
> +	.bus		= &platform_bus_type,
> +	.probe		= bfin_cf_probe,
> +	.remove		= __devexit_p(bfin_cf_remove),
> +	.suspend 	= pcmcia_socket_dev_suspend,
> +	.resume 	= pcmcia_socket_dev_resume,
> +};

NAK.  All platform device drivers must be of type 'struct platform_driver'.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2008-05-12 11:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 10:46 [PATCH 1/1] [PCMCIA]: add support the CF PCMCIA driver for Blackfin Bryan Wu
2008-05-12 11:37 ` Russell King [this message]
2008-05-13  8:36   ` Hennerich, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080512113726.GB15305@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=cooloney@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox