public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Cyrill Gorcunov <gorcunov@gmail.com>, "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Sam Ravnborg <sam@ravnborg.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: wakeup.lds.S - section ordering fix
Date: Mon, 12 May 2008 15:53:43 +0200	[thread overview]
Message-ID: <20080512135343.GA1725@elf.ucw.cz> (raw)
In-Reply-To: <20080511184638.GE6942@cvg>

On Sun 2008-05-11 22:46:38, Cyrill Gorcunov wrote:
> To allow linker to catch sections overlapping we have to declare
> them in appropriate order.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> 
> Please test and review

Looks okay to me, but I can't easily test it right now.

But I think Rafael tested identical patch, you can add my ACK in such
case.

								Pavel

> Index: linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/acpi/realmode/wakeup.lds.S	2008-05-11 20:21:58.000000000 +0400
> +++ linux-2.6.git/arch/x86/kernel/acpi/realmode/wakeup.lds.S	2008-05-11 22:34:42.000000000 +0400
> @@ -12,11 +12,6 @@ ENTRY(_start)
>  
>  SECTIONS
>  {
> -	. = HEADER_OFFSET;
> -	.header : {
> -		 *(.header)
> -	}
> -
>  	. = 0;
>  	.text : {
>  		 *(.text*)
> @@ -50,6 +45,11 @@ SECTIONS
>  		__bss_end = .;
>  	}
>  
> +	. = HEADER_OFFSET;
> +	.header : {
> +		*(.header)
> +	}
> +
>  	. = ALIGN(16);
>  	_end = .;
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2008-05-12 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-11 18:46 [PATCH] x86: wakeup.lds.S - section ordering fix Cyrill Gorcunov
2008-05-12 13:53 ` Pavel Machek [this message]
2008-05-12 14:14   ` Cyrill Gorcunov
2008-05-13 12:10     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080512135343.GA1725@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox