* [RFC] [PATCH] dlm: tcp_connect_to_sock should check for -EINVAL, not EINVAL
@ 2008-05-11 20:01 Marcin Slusarz
2008-05-12 15:20 ` David Teigland
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Slusarz @ 2008-05-11 20:01 UTC (permalink / raw)
To: LKML; +Cc: Christine Caulfield, David Teigland, cluster-devel
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Christine Caulfield <ccaulfie@redhat.com>
Cc: David Teigland <teigland@redhat.com>
Cc: cluster-devel@redhat.com
---
it's probably a typo, but I'm not sure
please check if it's the right fix (maybe this condition should be dropped?)
(compile tested only)
---
fs/dlm/lowcomms.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
--- a/fs/dlm/lowcomms.c
+++ b/fs/dlm/lowcomms.c
@@ -930,7 +930,7 @@ out_err:
* errors we try again until the max number of retries is reached.
*/
if (result != -EHOSTUNREACH && result != -ENETUNREACH &&
- result != -ENETDOWN && result != EINVAL
+ result != -ENETDOWN && result != -EINVAL
&& result != -EPROTONOSUPPORT) {
lowcomms_connect_sock(con);
result = 0;
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC] [PATCH] dlm: tcp_connect_to_sock should check for -EINVAL, not EINVAL
2008-05-11 20:01 [RFC] [PATCH] dlm: tcp_connect_to_sock should check for -EINVAL, not EINVAL Marcin Slusarz
@ 2008-05-12 15:20 ` David Teigland
0 siblings, 0 replies; 2+ messages in thread
From: David Teigland @ 2008-05-12 15:20 UTC (permalink / raw)
To: Marcin Slusarz; +Cc: LKML
On Sun, May 11, 2008 at 10:01:29PM +0200, Marcin Slusarz wrote:
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Christine Caulfield <ccaulfie@redhat.com>
> Cc: David Teigland <teigland@redhat.com>
> Cc: cluster-devel@redhat.com
> ---
> it's probably a typo, but I'm not sure
> please check if it's the right fix (maybe this condition should be dropped?)
> (compile tested only)
Thanks, I've added this to dlm.git.
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-12 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-11 20:01 [RFC] [PATCH] dlm: tcp_connect_to_sock should check for -EINVAL, not EINVAL Marcin Slusarz
2008-05-12 15:20 ` David Teigland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox