Re: [PATCH resend] m68knommu: Add info about removing mcfserial

Re: [PATCH resend] m68knommu: Add info about removing mcfserial

[Alan Cox]

On Mon, 12 May 2008 23:20:23 +0200
Sebastian Siewior <lkml@ml.breakpoint.cc> wrote:

> From: Sebastian Siewior <bigeasy@linutronix.de>
> 
> Schedule a removal for this driver. Alternative driver is available for
> a while now.
> 
> Signed-off-by: Sebastian Siewior <bigeasy@linutronix.de>

Acked-by: Alan Cox <alan@redhat.com>

[PATCH resend] m68knommu: Add info about removing mcfserial

[Sebastian Siewior]

From: Sebastian Siewior <bigeasy@linutronix.de>

Schedule a removal for this driver. Alternative driver is available for
a while now.

Signed-off-by: Sebastian Siewior <bigeasy@linutronix.de>
---
Greg is fine with this http://lkml.org/lkml/2008/4/30/561

 Documentation/feature-removal-schedule.txt |    8 ++++++++
 drivers/serial/Kconfig                     |    6 +++++-
 drivers/serial/mcfserial.c                 |    1 +
 3 files changed, 14 insertions(+), 1 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 3c35d45..5b3f31f 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -289,6 +289,14 @@ Who:	Glauber Costa <gcosta@redhat.com>
 
 ---------------------------
 
+What:	old style serial driver for ColdFire (CONFIG_SERIAL_COLDFIRE)
+When:	2.6.28
+Why:	This driver still uses the old interface and has been replaced
+	by CONFIG_SERIAL_MCF.
+Who:	Sebastian Siewior <sebastian@breakpoint.cc>
+
+---------------------------
+
 What:	/sys/o2cb symlink
 When:	January 2010
 Why:	/sys/fs/o2cb is the proper location for this information - /sys/o2cb
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 36acbcc..62e6eb1 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -976,11 +976,15 @@ config SERIAL_68328_RTS_CTS
 	depends on SERIAL_68328
 
 config SERIAL_COLDFIRE
-	bool "ColdFire serial support"
+	bool "ColdFire serial support (DEPRECATED)"
 	depends on COLDFIRE
 	help
 	  This driver supports the built-in serial ports of the Motorola ColdFire
 	  family of CPUs.
+	  This driver is deprecated because it supports only the old interface
+	  for serial drivers and features like magic keys are not working.
+	  Please switch to the new style driver because this driver will be
+	  removed soon.
 
 config SERIAL_MCF
 	bool "Coldfire serial support (new style driver)"
diff --git a/drivers/serial/mcfserial.c b/drivers/serial/mcfserial.c
index 43af40d..56007cc 100644
--- a/drivers/serial/mcfserial.c
+++ b/drivers/serial/mcfserial.c
@@ -1,3 +1,4 @@
+#warning This driver is deprecated. Check Kconfig for details.
 /*
  * mcfserial.c -- serial driver for ColdFire internal UARTS.
  *
-- 
1.5.5.1