From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Gianni Tedesco <gxt@cs.nott.ac.uk>,
arges@linux.vnet.ibm.com, Maynard Johnson <maynardj@us.ibm.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
linux-kernel@vger.kernel.org,
oprofile-list@lists.sourceforge.net, Mike Travis <travis@sgi.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: oprofile BUG() in current kernel.
Date: Tue, 13 May 2008 08:23:13 -0700 [thread overview]
Message-ID: <20080513082313.cbbe81af.akpm@linux-foundation.org> (raw)
In-Reply-To: <48296C96.8060000@cosmosbay.com>
On Tue, 13 May 2008 12:25:26 +0200 Eric Dumazet <dada1@cosmosbay.com> wrote:
> Current module loader only allocates percpu room by examining
> ".data.percpu" section and should be augmented to also look at
> ".data.percpu.shared_aligned"
> Or, change DEFINE_PER_CPU_SHARED_ALIGNED() for modules (to use
> ".data.percpu" only)
Well that's a little landmine. Seems that this was the first attempt to
use DEFINE_PER_CPU_SHARED_ALIGNED from within a module.
> Anyway, with the per_cpu conversion of cpu_buffer, we dont need to
> request cache_line alignment anymore
>
> [PATCH] oprofile: Dont request cache line alignment for cpu_buffer
Thanks. Silly me for looking at the nearly-one-year-old
DEFINE_PER_CPU_SHARED_ALIGNED and assuming that it worked :(
next prev parent reply other threads:[~2008-05-13 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 12:02 oprofile BUG() in current kernel Gianni Tedesco
2008-05-12 12:19 ` Vegard Nossum
2008-05-12 13:31 ` Gianni Tedesco
2008-05-12 14:11 ` Maynard Johnson
2008-05-12 16:38 ` Chris J Arges
2008-05-13 8:40 ` Andrew Morton
2008-05-13 9:01 ` Vegard Nossum
2008-05-13 9:41 ` Gianni Tedesco
2008-05-13 10:25 ` Eric Dumazet
2008-05-13 10:59 ` Gianni Tedesco
[not found] ` <482986B3.1090601@cosmosbay.com>
2008-05-13 14:38 ` Gianni Tedesco
2008-05-13 15:23 ` Andrew Morton [this message]
2008-05-13 15:12 ` [PATCH] per_cpu: fix DEFINE_PER_CPU_SHARED_ALIGNED for modules Eric Dumazet
2008-05-14 5:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513082313.cbbe81af.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arges@linux.vnet.ibm.com \
--cc=dada1@cosmosbay.com \
--cc=fenghua.yu@intel.com \
--cc=gxt@cs.nott.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=maynardj@us.ibm.com \
--cc=oprofile-list@lists.sourceforge.net \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox