From: Jeremy Higdon <jeremy@sgi.com>
To: Jes Sorensen <jes@sgi.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
dgc@sgi.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, jens.axboe@oracle.com,
stable@kernel.org
Subject: Re: [PATCH] drivers/scsi/qla1280.c; was Re: Buffered I/O to block device very slow and other SCSI issues...
Date: Tue, 13 May 2008 01:58:04 -0700 [thread overview]
Message-ID: <20080513085804.GL41683@sgi.com> (raw)
In-Reply-To: <48294022.2070002@sgi.com>
On Tue, May 13, 2008 at 09:15:46AM +0200, Jes Sorensen wrote:
> Andrew Morton wrote:
> >>--- a/drivers/scsi/qla1280.c 2008-05-03 11:59:44.000000000 -0700
> >>+++ b/drivers/scsi/qla1280.c 2008-05-10 21:32:23.451341969 -0700
> >>@@ -2007,7 +2007,7 @@ qla1280_set_defaults(struct scsi_qla_hos
> >> nv->bus[bus].config_2.req_ack_active_negation = 1;
> >> nv->bus[bus].config_2.data_line_active_negation = 1;
> >> nv->bus[bus].selection_timeout = 250;
> >>- nv->bus[bus].max_queue_depth = 256;
> >>+ nv->bus[bus].max_queue_depth = 32;
> >>
> >> if (IS_ISP1040(ha)) {
> >> nv->bus[bus].bus_reset_delay = 3;
> >>@@ -2051,7 +2051,7 @@ qla1280_config_target(struct scsi_qla_ho
> >> status = qla1280_mailbox_command(ha, 0x0f, mb);
> >>
> >> /* Save Tag queuing enable flag. */
> >>- flag = (BIT_0 << target) & mb[0];
> >>+ flag = (BIT_0 << target);
> >> if (nv->bus[bus].target[target].parameter.tag_queuing)
> >> ha->bus_settings[bus].qtag_enables |= flag;
> >
> >Thanks. I tagged this for a -stable backport (assuming that is
> >appropriate?)
> >
>
> Sounds good, given the nature of this it should go into stable as well
> as current.
I agree.
> Acked-by: Jes Sorensen <jes@sgi.com>
jeremy
prev parent reply other threads:[~2008-05-13 8:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 23:16 Buffered I/O to block device very slow and other SCSI issues David Chinner
2008-03-20 1:08 ` Jeremy Higdon
2008-03-20 10:20 ` Andrew Morton
2008-03-20 11:59 ` Mike Snitzer
2008-03-23 23:11 ` Jeremy Higdon
2008-05-12 6:17 ` [PATCH] drivers/scsi/qla1280.c; was " Jeremy Higdon
2008-05-12 11:43 ` David Chinner
2008-05-13 0:18 ` Andrew Morton
2008-05-13 7:15 ` Jes Sorensen
2008-05-13 8:58 ` Jeremy Higdon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513085804.GL41683@sgi.com \
--to=jeremy@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=dgc@sgi.com \
--cc=jens.axboe@oracle.com \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox