From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Helsley <matthltc@us.ibm.com>
Cc: menage@google.com, pj@sgi.com, xemul@openvz.org,
balbir@in.ibm.com, serue@us.ibm.com,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [RFC/PATCH 1/8]: CGroup Files: Add locking mode to cgroups control files
Date: Tue, 13 May 2008 13:43:54 -0700 [thread overview]
Message-ID: <20080513134354.18d3f6a3.akpm@linux-foundation.org> (raw)
In-Reply-To: <1210711138.21217.49.camel@localhost.localdomain>
On Tue, 13 May 2008 13:38:58 -0700
Matthew Helsley <matthltc@us.ibm.com> wrote:
> > > + char static_buffer[64];
>
> > I'm trying to work out what protects static_buffer?
>
> One of us must be having a brain cramp because it looks to me like the
> buffer doesn't need protection -- it's on the stack. It's probably me
> but I'm just not seeing how this use is unsafe..
doh. Well it had me going...
> Uh, it is on stack. It doesn't use the C keyword "static". It's just
> poorly-named.
That depends upon one's objectives in choosing a name ;)
next prev parent reply other threads:[~2008-05-13 20:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 6:37 [RFC/PATCH 0/8]: CGroup Files: Clean up locking and boilerplate menage
2008-05-13 6:37 ` [RFC/PATCH 1/8]: CGroup Files: Add locking mode to cgroups control files menage
2008-05-13 9:23 ` Li Zefan
2008-05-13 21:07 ` Paul Menage
2008-05-14 1:30 ` Li Zefan
2008-05-14 1:40 ` Paul Menage
2008-05-13 20:01 ` Andrew Morton
2008-05-13 20:38 ` Matthew Helsley
2008-05-13 20:43 ` Andrew Morton [this message]
2008-05-13 21:17 ` Paul Menage
2008-05-13 21:32 ` Andrew Morton
2008-05-13 21:46 ` Paul Menage
2008-05-14 1:59 ` Paul Jackson
2008-05-13 6:37 ` [RFC/PATCH 2/8]: CGroup Files: Add a cgroup write_string control file method menage
2008-05-13 20:07 ` Andrew Morton
2008-05-13 21:01 ` Paul Menage
2008-05-13 20:44 ` Matt Helsley
2008-05-13 6:37 ` [RFC/PATCH 3/8]: CGroup Files: Move the release_agent file to use typed handlers menage
2008-05-13 20:08 ` Andrew Morton
2008-05-13 21:32 ` Paul Menage
2008-05-13 6:37 ` [RFC/PATCH 4/8]: CGroup Files: Move notify_on_release file to separate write handler menage
2008-05-13 6:37 ` [RFC/PATCH 5/8]: CGroup Files: Turn attach_task_by_pid directly into a cgroup " menage
2008-05-13 6:37 ` [RFC/PATCH 6/8]: CGroup Files: Remove cpuset_common_file_write() menage
2008-05-13 20:11 ` Andrew Morton
2008-05-13 21:27 ` Paul Menage
2008-05-13 6:37 ` [RFC/PATCH 7/8]: CGroup Files: Convert devcgroup_access_write() into a cgroup write_string() handler menage
2008-05-13 6:37 ` [RFC/PATCH 8/8]: CGroup Files: Convert res_counter_write() to be a cgroups " menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080513134354.18d3f6a3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=menage@google.com \
--cc=pj@sgi.com \
--cc=serue@us.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox