From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758671AbYENCNh (ORCPT ); Tue, 13 May 2008 22:13:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754862AbYENCN0 (ORCPT ); Tue, 13 May 2008 22:13:26 -0400 Received: from ns1.suse.de ([195.135.220.2]:50112 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753682AbYENCNZ (ORCPT ); Tue, 13 May 2008 22:13:25 -0400 Date: Tue, 13 May 2008 19:03:33 -0700 From: Greg KH To: Michael Krufky Cc: linux-kernel@vger.kernel.org, stable@kernel.org, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Chuck Ebbert , Domenico Andreoli , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Hans-Frieder Vogt , Felix Apitzsch , Antti Palosaari , Albert Comerma , Patrick Boettcher , Mauro Carvalho Chehab , Michel Morisot Subject: Re: [patch 01/37] V4L/DVB (7473): PATCH for various Dibcom based devices Message-ID: <20080514020333.GA30079@suse.de> References: <20080513200453.064446337@mini.kroah.org> <20080513201053.GA31167@suse.de> <20080513201120.GB31167@suse.de> <37219a840805131827v5faf7710pf0b3f67e570bdc7f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37219a840805131827v5faf7710pf0b3f67e570bdc7f@mail.gmail.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 13, 2008 at 09:27:30PM -0400, Michael Krufky wrote: > On Tue, May 13, 2008 at 4:11 PM, Greg KH wrote: > > 2.6.25-stable review patch. If anyone has any objections, please let us know. > > > > ------------------ > > > > From: Albert Comerma > > > > patch 6ca8f0b97473dcef3a754bab5239dcfcdd00b244 upstream > > > > This patch introduces support for dvb-t for the following DiBcom based cards: > > > > - Terratec Cinergy HT USB XE (USB-ID: 0ccd:0058) > > - Terratec Cinergy HT Express (USB-ID: 0ccd:0060) > > - Pinnacle 320CX (USB-ID: 2304:022e) > > - Pinnacle PCTV72e (USB-ID: 2304:0236) > > - Pinnacle PCTV73e (USB-ID: 2304:0237) > > - Yuan EC372S (USB-ID: 1164:1edc) > > > > Signed-off-by: Hans-Frieder Vogt > > Signed-off-by: Felix Apitzsch > > Signed-off-by: Antti Palosaari > > Signed-off-by: Albert Comerma > > Signed-off-by: Patrick Boettcher > > Signed-off-by: Mauro Carvalho Chehab > > Cc: Michel Morisot > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > drivers/media/dvb/dvb-usb/dib0700_devices.c | 259 ++++++++++++++++++++++++---- > > drivers/media/dvb/dvb-usb/dvb-usb-ids.h | 9 > > 2 files changed, 238 insertions(+), 30 deletions(-) > > > This patch is entirely inappropriate for -stable Why do you say that? It adds new device ids for devices to a driver, which is find for stable. > Who sent this in? I did. > I usually send in the v4l-dvb backports for -stable, and this was > never in my queue, not to mention that it doesn't qualify, based on > the -stable rules. I think it does qualify and I've been asking for feedback about this for the past week to everyone on the signed-off-lines above with no real objections :) openSUSE had a user that requested this patch be added as they had hardware that needed this patch to work properly on 2.6.25. As it only added device ids, I didn't see the problem with it. Does it cause any problems that you can see? thanks, greg k-h