From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: sam@ravnborg.org, acme@redhat.com, srostedt@redhat.com,
linux-kernel@vger.kernel.org, pq@iki.fi, proski@gnu.org,
sandmann@redhat.com, rostedt@goodmis.org, a.p.zijlstra@chello.nl
Subject: Re: [PATCH 0/2]: Add sparc64 ftrace support.
Date: Wed, 14 May 2008 09:18:43 +0200 [thread overview]
Message-ID: <20080514071843.GA21324@elte.hu> (raw)
In-Reply-To: <20080514.001150.119391237.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Date: Wed, 14 May 2008 09:01:48 +0200
>
> > (i also sort by length to make it visually more appealing. "Reverse
> > christmas tree" sorting ;-)
>
> I do this for local variable declarations too.
yeah, same here:
--------------------------------->
static void
ftrace_record_ip(unsigned long ip)
{
struct dyn_ftrace *node;
unsigned long flags;
unsigned long key;
int resched;
int atomic;
int cpu;
[...]
<--------------------------------
for me the primary motivation isnt even merge conflicts in this case
(getting conflicts on this level is rare), but readability and making it
smooth to move the eye off the variable declarations.
IMO good code is obvious even without having to read the types, so the
less visually intrusive the variable declarations section is, the
better.
Ingo
next prev parent reply other threads:[~2008-05-14 7:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 5:06 [PATCH 0/2]: Add sparc64 ftrace support David Miller
2008-05-14 6:30 ` Ingo Molnar
2008-05-14 6:51 ` Sam Ravnborg
2008-05-14 7:01 ` Ingo Molnar
2008-05-14 7:11 ` David Miller
2008-05-14 7:18 ` Ingo Molnar [this message]
2008-05-17 4:01 ` [PATCH] ftrace: add have dynamic ftrace config for archs Steven Rostedt
2008-05-19 15:21 ` Ingo Molnar
2008-05-14 13:09 ` [PATCH 0/2]: Add sparc64 ftrace support Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080514071843.GA21324@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pq@iki.fi \
--cc=proski@gnu.org \
--cc=rostedt@goodmis.org \
--cc=sam@ravnborg.org \
--cc=sandmann@redhat.com \
--cc=srostedt@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox