The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Andreas Schwab <schwab@suse.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux/m68k <linux-m68k@vger.kernel.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: m68k: main.c:(.init.text+0x730): undefined reference to `strlen'
Date: Wed, 14 May 2008 19:48:01 +0400	[thread overview]
Message-ID: <20080514154801.GG6902@cvg> (raw)
In-Reply-To: <20080514153059.GA22115@cs181133002.pp.htv.fi>

[Adrian Bunk - Wed, May 14, 2008 at 06:30:59PM +0300]
| On Wed, May 14, 2008 at 04:28:24PM +0200, Andreas Schwab wrote:
| > Adrian Bunk <bunk@kernel.org> writes:
| > 
| > > Or replace all the strlen stuff in include/asm-m68k/string.h with a 
| > 
| > I don't think the strlen macros has any influence in this case (it
| > already uses __builtin_strlen anyway).
| 
| The problem is that it sets __HAVE_ARCH_STRLEN, and therefore the 
| out-of-line function in lib/string.c is not built.
| 
| That breaks when gcc replaces a call to a different function with a call 
| to strlen().
| 
| > I'd rather guess that gcc is
| > expanding strncat internally to something involving strlen with
| > non-constant argument,
| 
| We agree on this one.
| 
| > although I cannot see how that can happen from a
| > quick look.
| 
| It isn't the first time we have these problems in the kernel...
| 
| > Andreas.
| 
| cu
| Adrian
| 
| -- 
| 
|        "Is there not promise of rain?" Ling Tan asked suddenly out
|         of the darkness. There had been need of rain for many days.
|        "Only a promise," Lao Er said.
|                                        Pearl S. Buck - Dragon Seed
| 
| 

Adrian, I've just sent the updated patch, and accidentally forget
to CC you - please take a look on http://lkml.org/lkml/2008/5/14/267

		- Cyrill -

  reply	other threads:[~2008-05-14 15:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-14  8:02 m68k: main.c:(.init.text+0x730): undefined reference to `strlen' Geert Uytterhoeven
2008-05-14  8:37 ` Andreas Schwab
2008-05-14  9:57   ` Cyrill Gorcunov
2008-05-14 10:48     ` Cyrill Gorcunov
2008-05-14 14:10   ` Adrian Bunk
2008-05-14 14:28     ` Andreas Schwab
2008-05-14 14:40       ` Cyrill Gorcunov
2008-05-14 14:55         ` Andreas Schwab
2008-05-14 14:58           ` Cyrill Gorcunov
2008-05-14 15:14           ` Cyrill Gorcunov
2008-05-14 15:27             ` Andreas Schwab
2008-05-14 15:31               ` Cyrill Gorcunov
2008-05-14 20:14               ` Geert Uytterhoeven
2008-05-14 14:51       ` Cyrill Gorcunov
2008-05-14 15:30       ` Adrian Bunk
2008-05-14 15:48         ` Cyrill Gorcunov [this message]
2008-05-14 15:56           ` Adrian Bunk
2008-05-14 16:03             ` Cyrill Gorcunov
2008-05-14 14:55 ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080514154801.GG6902@cvg \
    --to=gorcunov@gmail.com \
    --cc=bunk@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox