From: Matthew Wilcox <matthew@wil.cx>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove argument from open_softirq which is always NULL
Date: Thu, 15 May 2008 09:22:10 -0600 [thread overview]
Message-ID: <20080515152210.GL9921@parisc-linux.org> (raw)
In-Reply-To: <20080515141537.GA22826@beyonder.ift.unesp.br>
On Thu, May 15, 2008 at 11:15:37AM -0300, Carlos R. Mafra wrote:
> This observation has already been made by Matthew Wilcox in June 2002
> (http://www.cs.helsinki.fi/linux/linux-kernel/2002-25/0687.html)
>
> "I notice that none of the current softirq routines use the data element
> passed to them."
>
> and the situation hasn't changed since them. So it appears we can safely
> remove that extra argument to save 128 (54) bytes of kernel data (text).
>
> Signed-off-by: Carlos R. Mafra <crmafra@ift.unesp.br>
Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-05-15 15:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 14:15 [PATCH] Remove argument from open_softirq which is always NULL Carlos R. Mafra
2008-05-15 15:22 ` Matthew Wilcox [this message]
2008-05-16 11:57 ` Ingo Molnar
2008-05-16 18:28 ` Paul E. McKenney
2008-05-16 19:52 ` Carlos R. Mafra
2008-05-17 4:24 ` [PATCH] Remove unused argument from functions invoked by open_softirq Carlos R. Mafra
2008-05-17 6:03 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515152210.GL9921@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox