public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Vegard Nossum" <vegard.nossum@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"S.Çağlar Onur" <caglar@pardus.org.tr>,
	Valdis.Kletnieks@vt.edu, "Matt Mackall" <mpm@selenic.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [BISECTED] Lots of "rescheduling IPIs" in powertop
Date: Thu, 15 May 2008 18:10:10 +0200	[thread overview]
Message-ID: <20080515161010.GA9506@alberich.amd.com> (raw)
In-Reply-To: <87prrp6ri9.fsf@basil.nowhere.org>

On Wed, May 14, 2008 at 01:42:54PM +0200, Andi Kleen wrote:
> Andreas Herrmann <andreas.herrmann3@amd.com> writes:
> >
> > It depends on the CPU. For AMD CPUs that support MWAIT this is wrong.
> > Family 0x10 and 0x11 CPUs will enter C1 on HLT. Powersavings then
>                                 ^ not

Not sure what you meant by your comment.
Maybe you should re-read the paragraph.

It's as simple as that:
If OS executes Halt the core enters C1.
The core exits C1 if an interrupt is received.

> > It might be best to switch off the mwait flag for these AMD CPU
> > families like it was introduced with commit
> > f039b754714a422959027cb18bb33760eb8153f0 (x86: Don't use MWAIT on AMD
> > Family 10)
> 
> Then you have to special case everything again. We still need to 
> work out if the P4 is even correct here or not, but if it's not
> i would rather quirk the cpuid reporting on it.

I just want to ensure that for AMD family 0x10 and 0x11 halt and not
mwait is executed when the core is idle.


Andreas



  reply	other threads:[~2008-05-15 16:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 20:42 [BISECTED] Lots of "rescheduling IPIs" in powertop Vegard Nossum
2008-05-13 20:54 ` Andi Kleen
2008-05-13 21:09   ` Vegard Nossum
2008-05-13 21:19     ` Andi Kleen
2008-05-14  4:02       ` Arjan van de Ven
2008-05-14  6:58         ` Andi Kleen
2008-05-14 13:55           ` Arjan van de Ven
2008-05-14 15:21             ` Andi Kleen
2008-05-14  6:00       ` Vegard Nossum
2008-05-14  6:56 ` Ingo Molnar
2008-05-14  7:11   ` Vegard Nossum
2008-05-14  9:09   ` Andreas Herrmann
2008-05-14 11:42     ` Andi Kleen
2008-05-15 16:10       ` Andreas Herrmann [this message]
2008-05-16  8:40     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080515161010.GA9506@alberich.amd.com \
    --to=andreas.herrmann3@amd.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=andi@firstfloor.org \
    --cc=caglar@pardus.org.tr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mpm@selenic.com \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox