From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755897AbYEOREU (ORCPT ); Thu, 15 May 2008 13:04:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751212AbYEOREJ (ORCPT ); Thu, 15 May 2008 13:04:09 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:44317 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbYEOREI (ORCPT ); Thu, 15 May 2008 13:04:08 -0400 Date: Thu, 15 May 2008 11:04:07 -0600 From: Matthew Wilcox To: Arnaldo Carvalho de Melo , Jesse Barnes , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-rt-users@vger.kernel.org Subject: Re: [PATCH][PCI]: Introduce pci_find_capability_cached and make MSI use it Message-ID: <20080515170407.GM9921@parisc-linux.org> References: <20080515160426.GD14846@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080515160426.GD14846@ghostprotocols.net> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 15, 2008 at 01:04:26PM -0300, Arnaldo Carvalho de Melo wrote: > So I implemented pci_find_capability_cached and made MSI use it > for good measure, please consider applying. As I told you on IRC, this is just the MSI code being complete crap. It should be caching the offset itself. We shouldn't have this extra array in the struct pci_dev just because MSI is broken. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."