From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH][PCI]: Introduce pci_find_capability_cached and make MSI use it
Date: Thu, 15 May 2008 14:10:03 -0300 [thread overview]
Message-ID: <20080515171003.GF14846@ghostprotocols.net> (raw)
In-Reply-To: <20080515170407.GM9921@parisc-linux.org>
Em Thu, May 15, 2008 at 11:04:07AM -0600, Matthew Wilcox escreveu:
> On Thu, May 15, 2008 at 01:04:26PM -0300, Arnaldo Carvalho de Melo wrote:
> > So I implemented pci_find_capability_cached and made MSI use it
> > for good measure, please consider applying.
>
> As I told you on IRC, this is just the MSI code being complete crap.
> It should be caching the offset itself. We shouldn't have this extra
> array in the struct pci_dev just because MSI is broken.
Well, we can certainly do that, its just that I did this first and
thought that perhaps there could be some other users, but I see that 44
extra bytes per pci_dev can be a pain if the only one to reap benefits
is MSI, can't you think of any other users? I couldn't detect any so far
in my admitedly limited testing.
- Arnaldo
next prev parent reply other threads:[~2008-05-15 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 16:04 [PATCH][PCI]: Introduce pci_find_capability_cached and make MSI use it Arnaldo Carvalho de Melo
2008-05-15 17:02 ` Arnaldo Carvalho de Melo
2008-05-15 17:04 ` Matthew Wilcox
2008-05-15 17:10 ` Arnaldo Carvalho de Melo [this message]
2008-05-16 17:44 ` Jesse Barnes
2008-05-16 18:33 ` Arnaldo Carvalho de Melo
2008-05-16 19:01 ` Jesse Barnes
2008-05-16 19:10 ` Arnaldo Carvalho de Melo
2008-05-19 4:48 ` [PATCH] msi: skip calling pci_find_capability from msi_set_mask_bits Hidetoshi Seto
2008-05-19 20:11 ` Jesse Barnes
2008-05-19 20:26 ` Arnaldo Carvalho de Melo
2008-05-20 19:56 ` Arnaldo Carvalho de Melo
2008-05-20 20:06 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515171003.GF14846@ghostprotocols.net \
--to=acme@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox