From: "John W. Linville" <linville@tuxdriver.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Daniel Drake <dsd@gentoo.org>,
Ulrich Kunitz <kune@deine-taler.de>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer
Date: Thu, 15 May 2008 15:16:47 -0400 [thread overview]
Message-ID: <20080515191647.GB17690@tuxdriver.com> (raw)
In-Reply-To: <20080516.001215.39152691.anemo@mba.ocn.ne.jp>
On Fri, May 16, 2008 at 12:12:15AM +0900, Atsushi Nemoto wrote:
> The zd1211rw driver uses unaligned stack buffer for USB control
> message. But it might cause stack corruption on non-coherent
> platform, such as MIPS. Use DMA-aware buffers for USB transfer.
>
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Nemoto,
This looks like a reasonable fix to me. I would prefer to see a
comment in the code indicating why you are reusing the "p" buffer
instead of simply using "ret" directly. Also, I think the style
suggestion by Michael Buesch would make the code appear more idiomatic
as well.
Thanks!
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-05-15 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 15:12 [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer Atsushi Nemoto
2008-05-15 15:42 ` Michael Buesch
2008-05-15 19:16 ` John W. Linville [this message]
2008-05-16 8:27 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515191647.GB17690@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=dsd@gentoo.org \
--cc=kune@deine-taler.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox