public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Vegard Nossum <vegard.nossum@gmail.com>, Andi Kleen <ak@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	"S.??a??lar Onur" <caglar@pardus.org.tr>,
	Valdis.Kletnieks@vt.edu, Matt Mackall <mpm@selenic.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [BISECTED] Lots of "rescheduling IPIs" in powertop
Date: Fri, 16 May 2008 10:40:59 +0200	[thread overview]
Message-ID: <20080516084059.GA31574@elte.hu> (raw)
In-Reply-To: <20080514090923.GC5607@alberich.amd.com>


* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> > > Recap: powertop shows between 200-400 wakeups/second with the 
> > > description "<kernel IPI>: Rescheduling interrupts" when all 
> > > processors have load (e.g. I need to run two busy-loops on my 
> > > 2-CPU system for this to show up).
> > 
> > ok, could you try the fix below? It was a mistake to make mwait use 
> > dependent on power considerations - on a desktop CPU it is unlikely 
> > to use more power than a simple HLT - and the IPIs are extra 
> > scheduling latency and extra power used.
> 
> It depends on the CPU. For AMD CPUs that support MWAIT this is wrong. 
> Family 0x10 and 0x11 CPUs will enter C1 on HLT. Powersavings then 
> depend on a clock divisor and current Pstate of the core.
> 
> If all cores of a processor are in halt state (C1) the processor can 
> enter the C1E (C1 enhanced) state. If mwait is used this will never 
> happen.
> 
> Thus HLT saves more power than MWAIT here.
> 
> It might be best to switch off the mwait flag for these AMD CPU 
> families like it was introduced with commit 
> f039b754714a422959027cb18bb33760eb8153f0 (x86: Don't use MWAIT on AMD 
> Family 10)

agreed, that looks like the cleanest solution. Could you please send a 
patch for that, ontop of my patch?

	Ingo

      parent reply	other threads:[~2008-05-16  8:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 20:42 [BISECTED] Lots of "rescheduling IPIs" in powertop Vegard Nossum
2008-05-13 20:54 ` Andi Kleen
2008-05-13 21:09   ` Vegard Nossum
2008-05-13 21:19     ` Andi Kleen
2008-05-14  4:02       ` Arjan van de Ven
2008-05-14  6:58         ` Andi Kleen
2008-05-14 13:55           ` Arjan van de Ven
2008-05-14 15:21             ` Andi Kleen
2008-05-14  6:00       ` Vegard Nossum
2008-05-14  6:56 ` Ingo Molnar
2008-05-14  7:11   ` Vegard Nossum
2008-05-14  9:09   ` Andreas Herrmann
2008-05-14 11:42     ` Andi Kleen
2008-05-15 16:10       ` Andreas Herrmann
2008-05-16  8:40     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080516084059.GA31574@elte.hu \
    --to=mingo@elte.hu \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=ak@suse.de \
    --cc=andreas.herrmann3@amd.com \
    --cc=caglar@pardus.org.tr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox