* [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F
@ 2008-01-18 9:58 Akira Tsukamoto
2008-05-16 8:05 ` Atsushi Nemoto
2008-05-16 8:13 ` Atsushi Nemoto
0 siblings, 2 replies; 6+ messages in thread
From: Akira Tsukamoto @ 2008-01-18 9:58 UTC (permalink / raw)
To: gregkh, linux-usb, linux-kernel, linux-usb-devel
pl2303: add support for RATOC REX-USB60F
This patch adds support for RATOC REX-USB60F Serial Adapters,
which is widely used in Japan recently.
Signed-off-by: Akira Tsukamoto <akirat@rd.scei.sony.co.jp>
---
diff -uprX dontdiff linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c linux-2.6.24-rc8/drivers/usb/serial/pl2303.c
--- linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c 2008-01-18 18:11:51.000000000 +0900
+++ linux-2.6.24-rc8/drivers/usb/serial/pl2303.c 2008-01-18 18:43:28.000000000 +0900
@@ -65,6 +65,7 @@ static struct usb_device_id id_table []
{ USB_DEVICE(ITEGNO_VENDOR_ID, ITEGNO_PRODUCT_ID_2080) },
{ USB_DEVICE(MA620_VENDOR_ID, MA620_PRODUCT_ID) },
{ USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID) },
+ { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID_USB60F) },
{ USB_DEVICE(TRIPP_VENDOR_ID, TRIPP_PRODUCT_ID) },
{ USB_DEVICE(RADIOSHACK_VENDOR_ID, RADIOSHACK_PRODUCT_ID) },
{ USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
diff -uprX dontdiff linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.h linux-2.6.24-rc8/drivers/usb/serial/pl2303.h
--- linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.h 2008-01-18 18:11:51.000000000 +0900
+++ linux-2.6.24-rc8/drivers/usb/serial/pl2303.h 2008-01-18 18:42:28.000000000 +0900
@@ -35,6 +35,7 @@
#define RATOC_VENDOR_ID 0x0584
#define RATOC_PRODUCT_ID 0xb000
+#define RATOC_PRODUCT_ID_USB60F 0xb020
#define TRIPP_VENDOR_ID 0x2478
#define TRIPP_PRODUCT_ID 0x2008
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F 2008-01-18 9:58 [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F Akira Tsukamoto @ 2008-05-16 8:05 ` Atsushi Nemoto 2008-05-16 8:13 ` Atsushi Nemoto 1 sibling, 0 replies; 6+ messages in thread From: Atsushi Nemoto @ 2008-05-16 8:05 UTC (permalink / raw) To: akirat; +Cc: gregkh, linux-usb, linux-kernel, linux-usb-devel On Fri, 18 Jan 2008 18:58:28 +0900, Akira Tsukamoto <akirat@rd.scei.sony.co.jp> wrote: > pl2303: add support for RATOC REX-USB60F > > This patch adds support for RATOC REX-USB60F Serial Adapters, > which is widely used in Japan recently. > > Signed-off-by: Akira Tsukamoto <akirat@rd.scei.sony.co.jp> > --- > > diff -uprX dontdiff linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c linux-2.6.24-rc8/drivers/usb/serial/pl2303.c > --- linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c 2008-01-18 18:11:51.000000000 +0900 > +++ linux-2.6.24-rc8/drivers/usb/serial/pl2303.c 2008-01-18 18:43:28.000000000 +0900 > @@ -65,6 +65,7 @@ static struct usb_device_id id_table [] > { USB_DEVICE(ITEGNO_VENDOR_ID, ITEGNO_PRODUCT_ID_2080) }, > { USB_DEVICE(MA620_VENDOR_ID, MA620_PRODUCT_ID) }, > { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID) }, > + { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID_USB60F) }, > { USB_DEVICE(TRIPP_VENDOR_ID, TRIPP_PRODUCT_ID) }, > { USB_DEVICE(RADIOSHACK_VENDOR_ID, RADIOSHACK_PRODUCT_ID) }, > { USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) }, Hi. I tried RATOC REX-USB60F with pl2303 driver and got oops in pl2303_open(). The pl2303 expects a interrupt_in endpoint but my device does not have interrupt_in. So this line in pl2303_open() cause oops. port->interrupt_in_urb->dev = serial->dev; This device works fine with the ftdi_sio driver, with "vendor=0x584 product=0xb020" module option. (0x584 is RATOC_VENDOR_ID and 0xb020 is RATOC_PRODUCT_ID_USB60F). Is the pl2303 driver appropriate for this device? Here is lsusb output: Bus 001 Device 003: ID 0584:b020 RATOC System, Inc. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 0 (Defined at Interface level) bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 8 idVendor 0x0584 RATOC System, Inc. idProduct 0xb020 bcdDevice 4.00 iManufacturer 1 RATOC Systems,Inc. iProduct 2 USB-Serial Converter iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 32 bNumInterfaces 1 bConfigurationValue 1 iConfiguration 0 bmAttributes 0xa0 (Bus Powered) Remote Wakeup MaxPower 100mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 2 USB-Serial Converter Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x02 EP 2 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0 Device Status: 0x0000 (Bus Powered) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F 2008-01-18 9:58 [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F Akira Tsukamoto 2008-05-16 8:05 ` Atsushi Nemoto @ 2008-05-16 8:13 ` Atsushi Nemoto 2008-05-16 15:13 ` Atsushi Nemoto 2008-05-16 16:53 ` Greg KH 1 sibling, 2 replies; 6+ messages in thread From: Atsushi Nemoto @ 2008-05-16 8:13 UTC (permalink / raw) To: akirat; +Cc: gregkh, linux-usb, linux-kernel, linux-usb # Sorry, resend with new linux-usb ML address. On Fri, 18 Jan 2008 18:58:28 +0900, Akira Tsukamoto <akirat@rd.scei.sony.co.jp> wrote: > pl2303: add support for RATOC REX-USB60F > > This patch adds support for RATOC REX-USB60F Serial Adapters, > which is widely used in Japan recently. > > Signed-off-by: Akira Tsukamoto <akirat@rd.scei.sony.co.jp> > --- > > diff -uprX dontdiff linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c linux-2.6.24-rc8/drivers/usb/serial/pl2303.c > --- linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c 2008-01-18 18:11:51.000000000 +0900 > +++ linux-2.6.24-rc8/drivers/usb/serial/pl2303.c 2008-01-18 18:43:28.000000000 +0900 > @@ -65,6 +65,7 @@ static struct usb_device_id id_table [] > { USB_DEVICE(ITEGNO_VENDOR_ID, ITEGNO_PRODUCT_ID_2080) }, > { USB_DEVICE(MA620_VENDOR_ID, MA620_PRODUCT_ID) }, > { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID) }, > + { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID_USB60F) }, > { USB_DEVICE(TRIPP_VENDOR_ID, TRIPP_PRODUCT_ID) }, > { USB_DEVICE(RADIOSHACK_VENDOR_ID, RADIOSHACK_PRODUCT_ID) }, > { USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) }, Hi. I tried RATOC REX-USB60F with pl2303 driver and got oops in pl2303_open(). The pl2303 expects a interrupt_in endpoint but my device does not have interrupt_in. So this line in pl2303_open() cause oops. port->interrupt_in_urb->dev = serial->dev; This device works fine with the ftdi_sio driver, with "vendor=0x584 product=0xb020" module option. (0x584 is RATOC_VENDOR_ID and 0xb020 is RATOC_PRODUCT_ID_USB60F). Is the pl2303 driver appropriate for this device? Here is lsusb output: Bus 001 Device 003: ID 0584:b020 RATOC System, Inc. Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 0 (Defined at Interface level) bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 8 idVendor 0x0584 RATOC System, Inc. idProduct 0xb020 bcdDevice 4.00 iManufacturer 1 RATOC Systems,Inc. iProduct 2 USB-Serial Converter iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 32 bNumInterfaces 1 bConfigurationValue 1 iConfiguration 0 bmAttributes 0xa0 (Bus Powered) Remote Wakeup MaxPower 100mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 2 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 255 Vendor Specific Subclass bInterfaceProtocol 255 Vendor Specific Protocol iInterface 2 USB-Serial Converter Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x02 EP 2 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0 Device Status: 0x0000 (Bus Powered) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F 2008-05-16 8:13 ` Atsushi Nemoto @ 2008-05-16 15:13 ` Atsushi Nemoto 2008-05-19 6:14 ` Akira Tsukamoto 2008-05-16 16:53 ` Greg KH 1 sibling, 1 reply; 6+ messages in thread From: Atsushi Nemoto @ 2008-05-16 15:13 UTC (permalink / raw) To: akirat; +Cc: gregkh, linux-usb, linux-kernel On Fri, 16 May 2008 17:13:45 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote: > This device works fine with the ftdi_sio driver, with "vendor=0x584 > product=0xb020" module option. (0x584 is RATOC_VENDOR_ID and 0xb020 > is RATOC_PRODUCT_ID_USB60F). > > Is the pl2303 driver appropriate for this device? For those who can read Japanese, here is a web page saying this device uses FTDI FT232BL chip. http://www.ratocsystems.com/info/news/2005/0524.html Tsukamoto-san, does your REX-USB60F work with pl2303 driver? If so, we have to do some trick to support this strange device (different driver for same USB ID), though I'm not sure that is possible. Otherwise, this patch can be used to support the device correctly. ------------------------------------------------------ Subject: [PATCH] usb-serial: Use ftdi_sio driver for RATOC REX-USB60F From: Atsushi Nemoto <anemo@mba.ocn.ne.jp> This patch reverts 57833ea6b95a3995149f1f6d1a8d8862ab7a0ba2 ("usb-serial: pl2303: add support for RATOC REX-USB60F") and add support for the device to ftdi_sio driver. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> --- drivers/usb/serial/ftdi_sio.c | 1 + drivers/usb/serial/ftdi_sio.h | 6 ++++++ drivers/usb/serial/pl2303.c | 1 - drivers/usb/serial/pl2303.h | 1 - 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index 5b349ec..3cee6fe 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -374,6 +374,7 @@ static struct usb_device_id id_table_combined [] = { .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, { USB_DEVICE(FTDI_VID, FTDI_OOCDLINK_PID), .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, + { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID_USB60F) }, { }, /* Optional parameter entry */ { } /* Terminating entry */ }; diff --git a/drivers/usb/serial/ftdi_sio.h b/drivers/usb/serial/ftdi_sio.h index 504edf8..a72f2c8 100644 --- a/drivers/usb/serial/ftdi_sio.h +++ b/drivers/usb/serial/ftdi_sio.h @@ -592,6 +592,12 @@ #define FIC_NEO1973_DEBUG_PID 0x5118 /* + * RATOC REX-USB60F + */ +#define RATOC_VENDOR_ID 0x0584 +#define RATOC_PRODUCT_ID_USB60F 0xb020 + +/* * BmRequestType: 1100 0000b * bRequest: FTDI_E2_READ * wValue: 0 diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index c605fb6..234c5ee 100644 --- a/drivers/usb/serial/pl2303.c +++ b/drivers/usb/serial/pl2303.c @@ -66,7 +66,6 @@ static struct usb_device_id id_table [] = { { USB_DEVICE(ITEGNO_VENDOR_ID, ITEGNO_PRODUCT_ID_2080) }, { USB_DEVICE(MA620_VENDOR_ID, MA620_PRODUCT_ID) }, { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID) }, - { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID_USB60F) }, { USB_DEVICE(TRIPP_VENDOR_ID, TRIPP_PRODUCT_ID) }, { USB_DEVICE(RADIOSHACK_VENDOR_ID, RADIOSHACK_PRODUCT_ID) }, { USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) }, diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h index 10cf872..3bdefe0 100644 --- a/drivers/usb/serial/pl2303.h +++ b/drivers/usb/serial/pl2303.h @@ -36,7 +36,6 @@ #define RATOC_VENDOR_ID 0x0584 #define RATOC_PRODUCT_ID 0xb000 -#define RATOC_PRODUCT_ID_USB60F 0xb020 #define TRIPP_VENDOR_ID 0x2478 #define TRIPP_PRODUCT_ID 0x2008 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F 2008-05-16 15:13 ` Atsushi Nemoto @ 2008-05-19 6:14 ` Akira Tsukamoto 0 siblings, 0 replies; 6+ messages in thread From: Akira Tsukamoto @ 2008-05-19 6:14 UTC (permalink / raw) To: Atsushi Nemoto; +Cc: gregkh, linux-usb, linux-kernel On Sat, 17 May 2008 00:13:56 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> mentioned: > > Tsukamoto-san, does your REX-USB60F work with pl2303 driver? If so, > we have to do some trick to support this strange device (different > driver for same USB ID), though I'm not sure that is possible. > Otherwise, this patch can be used to support the device correctly. I do not think REX-USB60F will work on pl2303 driver either based on your lsusb info. I saw your patch going into gregkh-2.6 tree and thank you for your fix. I will reexamine the REX-USB60F and I will reply to you only if the REX-USB60F requires some trick to support different driver for same USB ID. Thanks, Akira -- Akira Tsukamoto Sony Computer Entertainment Inc. Distributed OS Development Dept. Japan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F 2008-05-16 8:13 ` Atsushi Nemoto 2008-05-16 15:13 ` Atsushi Nemoto @ 2008-05-16 16:53 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Greg KH @ 2008-05-16 16:53 UTC (permalink / raw) To: Atsushi Nemoto; +Cc: akirat, gregkh, linux-usb, linux-kernel On Fri, May 16, 2008 at 05:13:45PM +0900, Atsushi Nemoto wrote: > # Sorry, resend with new linux-usb ML address. > > On Fri, 18 Jan 2008 18:58:28 +0900, Akira Tsukamoto <akirat@rd.scei.sony.co.jp> wrote: > > pl2303: add support for RATOC REX-USB60F > > > > This patch adds support for RATOC REX-USB60F Serial Adapters, > > which is widely used in Japan recently. > > > > Signed-off-by: Akira Tsukamoto <akirat@rd.scei.sony.co.jp> > > --- > > > > diff -uprX dontdiff linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c linux-2.6.24-rc8/drivers/usb/serial/pl2303.c > > --- linux-2.6.24-rc8.orig/drivers/usb/serial/pl2303.c 2008-01-18 18:11:51.000000000 +0900 > > +++ linux-2.6.24-rc8/drivers/usb/serial/pl2303.c 2008-01-18 18:43:28.000000000 +0900 > > @@ -65,6 +65,7 @@ static struct usb_device_id id_table [] > > { USB_DEVICE(ITEGNO_VENDOR_ID, ITEGNO_PRODUCT_ID_2080) }, > > { USB_DEVICE(MA620_VENDOR_ID, MA620_PRODUCT_ID) }, > > { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID) }, > > + { USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID_USB60F) }, > > { USB_DEVICE(TRIPP_VENDOR_ID, TRIPP_PRODUCT_ID) }, > > { USB_DEVICE(RADIOSHACK_VENDOR_ID, RADIOSHACK_PRODUCT_ID) }, > > { USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) }, > > Hi. I tried RATOC REX-USB60F with pl2303 driver and got oops in > pl2303_open(). The pl2303 expects a interrupt_in endpoint but my > device does not have interrupt_in. So this line in pl2303_open() > cause oops. > > port->interrupt_in_urb->dev = serial->dev; > > This device works fine with the ftdi_sio driver, with "vendor=0x584 > product=0xb020" module option. (0x584 is RATOC_VENDOR_ID and 0xb020 > is RATOC_PRODUCT_ID_USB60F). Ick, thanks for letting me know. > Is the pl2303 driver appropriate for this device? Based on your lsusb output, no, I think it is the ftdi_sio one. I'll go apply your patch. thanks again, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-05-19 6:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2008-01-18 9:58 [PATCH] usb-serial: pl2303: add support for RATOC REX-USB60F Akira Tsukamoto 2008-05-16 8:05 ` Atsushi Nemoto 2008-05-16 8:13 ` Atsushi Nemoto 2008-05-16 15:13 ` Atsushi Nemoto 2008-05-19 6:14 ` Akira Tsukamoto 2008-05-16 16:53 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox