From: Dave Jones <davej@codemonkey.org.uk>
To: Linux Kernel <linux-kernel@vger.kernel.org>, travis@sgi.com
Subject: Re: x86-64 NODES_SHIFT compile failure.
Date: Fri, 16 May 2008 13:01:52 -0400 [thread overview]
Message-ID: <20080516170152.GA7401@codemonkey.org.uk> (raw)
In-Reply-To: <20080516165456.GA30854@codemonkey.org.uk>
On Fri, May 16, 2008 at 12:54:56PM -0400, Dave Jones wrote:
> 4323838215184f5a2f081e0d17b8d60731b03164 added this line to x86's Kconfig..
>
> config NODES_SHIFT
> int
> + range 1 15 if X86_64
> default "6" if X86_64
> default "4" if X86_NUMAQ
> default "3"
>
> Selecting 15 causes:
>
> drivers/base/node.c: In function ‘node_read_distance’:
> drivers/base/node.c:140: error: size of array ‘type name’ is negative
>
> Should the upper limit be reduced to 14 (which compiles), or should
> the BUILD_BUG_ON be changed to somehow cope with this set of changes?
(actually that last part should be s/14/9/ )
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-05-16 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 16:54 x86-64 NODES_SHIFT compile failure Dave Jones
2008-05-16 17:01 ` Dave Jones [this message]
2008-05-16 17:44 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080516170152.GA7401@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox