public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: virtualization@lists.linux-foundation.org,
	Jeff Garzik <jeff@garzik.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>, "H. Anvin" <hpa@zytor.com>,
	Theodore Tso <tytso@mit.edu>, Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH 2/2] lguest: virtio-rng support
Date: Sat, 17 May 2008 14:46:39 +1000	[thread overview]
Message-ID: <200805171446.39814.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1210934981.6381.1.camel@johannes.berg>

On Friday 16 May 2008 20:49:41 Johannes Berg wrote:
> > +
> > +/* Our random number generator device reads from /dev/urandom into the Guest's
> > + * input buffers.  The usual case is that the Guest doesn't want random numbers
> > + * and so has no buffers although /dev/urandom is still readable, whereas
> > + * console is the reverse. 
>
> Is it really a good idea to use the hosts /dev/urandom to fill the
> guests /dev/random?

Technically it's up to rngd in the guest to decide whether to feed entropy
or not (ie. /dev/urandom or /dev/random).

If we use /dev/random in the host, we risk a DoS.  But since /dev/random
is 0666 on my system, perhaps noone actually cares?

Cheers,
Rusty.

  parent reply	other threads:[~2008-05-17  4:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15 18:48 Virt RNG? Jeff Garzik
2008-05-15 19:53 ` Jeremy Fitzhardinge
2008-05-15 20:26   ` Dor Laor
2008-05-15 20:31 ` Christian Borntraeger
2008-05-15 20:44   ` Jeff Garzik
2008-05-15 20:43 ` Jeff Dike
2008-05-15 23:43 ` Rusty Russell
2008-05-16  0:07   ` Henrique de Moraes Holschuh
2008-05-16  5:31   ` [PATCH 1/2] virtio: hardware random device Rusty Russell
2008-05-16  5:39     ` [PATCH 2/2] lguest: virtio-rng support Rusty Russell
2008-05-16 10:49       ` Johannes Berg
2008-05-16 20:25         ` H. Peter Anvin
2008-05-17  4:46         ` Rusty Russell [this message]
2008-05-17  4:50           ` H. Peter Anvin
2008-05-17  6:28             ` Rusty Russell
2008-05-17  6:43               ` Herbert Xu
2008-05-17  7:43                 ` Christian Borntraeger
2008-05-17 15:56                   ` H. Peter Anvin
2008-05-17  7:47               ` Jeremy Fitzhardinge
2008-05-19  9:05                 ` Rusty Russell
2008-05-19  9:10                   ` Jeremy Fitzhardinge
2008-05-19  9:28                     ` Rusty Russell
2008-05-19  9:45                       ` Jeremy Fitzhardinge
2008-05-17 15:57               ` H. Peter Anvin
2008-05-16  7:31     ` [PATCH 1/2] virtio: hardware random device Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805171446.39814.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=borntraeger@de.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=hpa@zytor.com \
    --cc=jeff@garzik.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=tytso@mit.edu \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox