Re: [PATCH] modules: Use a better scheme for refcounting

Eric Dumazet
2008-05-16T04:44:19Z

Andi Kleen a écrit :
> Eric Dumazet <dada1@cosmosbay.com> writes:
>
>> Instead of wasting NR_CPUS*128 bytes (on i386), we now use
>> num_possible_cpus*sizeof(local_t) bytes.
>>
>> On a typical distro, where NR_CPUS=8,
>>
>
> More typical would be NR_CPUS=128, with NR_CPUS=four digits
> when Mike Travis et.al. are finished
>
>
Yes. With NR_CPUS=4096, we save about half a megabyte per module. (!!!)

>> shiping 2000 modules, we reduce
>>
>
> Surely only the loaded modules count? Perhaps 20-30.
>
>
Well, I should have stated that this saving also takes place in the
module disk file.
(The "struct module" is included in it, in the
".gnu.linkonce.this_module" section)
Here on my distro, around 2000 modules are shiped.
> But it's a cool improvement. Very nice.
>
Thanks