Re: [RFC] x86: merge nmi_32-64 to nmi.c

Cyrill Gorcunov
2008-05-19T18:42:20Z

[Cyrill Gorcunov - Mon, May 19, 2008 at 10:07:53PM +0400]
| Btw, if someone is still watching this thread - I've found a bit strange
| behaviour of nmi on 32bit platform. Look, we have
|
| nmi_watchdog = NMI_DEFAULT
|
| by default which is the alias to NMI_DISABLED. Then lets assume that
| user put some option on command line, say for example he passes something
| like that
|
| nmi_watchdog=2
|
| which set it to
|
| nmi_watchdog = NMI_LOCAL_APIC
|
| with only that option passed we have sysfs entry created
| but I can't figure out why in proc_nmi_enabled() we have this
| code
|
| if (nmi_watchdog == NMI_DEFAULT) {
| if (lapic_watchdog_ok())
| nmi_watchdog = NMI_LOCAL_APIC;
| else
| nmi_watchdog = NMI_IO_APIC;
| }
|
| it seems it just _dont need_ at and could be safetly removed.
| Did I miss something?
|
| - Cyrill -

Ah, I found... sorry for noise, I'm shutting up ;)

- Cyrill -