Re: [RFC] x86: merge nmi_32-64 to nmi.c

Cyrill Gorcunov
2008-05-18T10:20:41Z

[Andi Kleen - Sun, May 18, 2008 at 12:15:32PM +0200]
|
| > Definitely, but we should do it at the Kconfig level which allows us
| > to have integer defines as well, so we end up with something like:
| >
| > static inline unsigned int get_nmi_count(int cpu)
| > {
| > return CONFIG_X86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
| > }
|
| #ifdef CONFIG_X86_64 would evaluate true even with CONFIG_X86_64 == 0
|
| -Andi
|

yes, but what to do with absence of __nmi_count on 32bit and die_nmi
uses different number of args? gcc follows both pathes anyway trying
to evaluate where I prefer it would not... I mean I've got errors
on compiling procedue 'cause of different number of args for die_nmi
used in 32bit mode. That is why I've asked Thomas if it possible to
add "panic" boot option for 32bit mode and make it familiar with 64bit
mode and merge them eventually.

- Cyrill -