Re: [RFC] x86: merge nmi_32-64 to nmi.c

Cyrill Gorcunov
2008-05-18T09:35:56Z

[Thomas Gleixner - Sun, May 18, 2008 at 11:09:22AM +0200]
| On Sun, 18 May 2008, Jeremy Fitzhardinge wrote:
|
| > Thomas Gleixner wrote:
| > > Definitely, but we should do it at the Kconfig level which allows us
| > > to have integer defines as well, so we end up with something like:
| > >
| > > static inline unsigned int get_nmi_count(int cpu)
| > > {
| > > return CONFIG_X86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
| > > }
| > >
| >
| > Unfortunately that doesn't work because when CONFIG_X86_64 isn't defined it
| > doesn't expand to 0. It would be nice if CONFIG_* expanded to 0/1, but we'd
| > need to change all the #ifdef CONFIG_* to #if CONFIG_*...
|
| You can have int type CONFIG_ which is always expanded. We have to add
| one of those though.
|
| Thanks,
| tglx
|

Thomas, unfortunetly as I see we can't go by a simple way like that,
these static funstions also hides the differen types and args list.
So even we could leave it as it is now, or could define them as macroses.
Anyway I'll try to find out how to handle this.

- Cyrill -