Re: [RFC] x86: merge nmi_32-64 to nmi.c

Jeremy Fitzhardinge
2008-05-18T07:26:08Z

Thomas Gleixner wrote:
> Definitely, but we should do it at the Kconfig level which allows us
> to have integer defines as well, so we end up with something like:
>
> static inline unsigned int get_nmi_count(int cpu)
> {
> return CONFIG_X86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
> }
>

Unfortunately that doesn't work because when CONFIG_X86_64 isn't defined
it doesn't expand to 0. It would be nice if CONFIG_* expanded to 0/1,
but we'd need to change all the #ifdef CONFIG_* to #if CONFIG_*...

J