Re: [RFC] x86: merge nmi_32-64 to nmi.c

Adrian Bunk
2008-05-18T18:10:23Z

On Sun, May 18, 2008 at 08:25:38AM +0100, Jeremy Fitzhardinge wrote:
> Thomas Gleixner wrote:
>> Definitely, but we should do it at the Kconfig level which allows us
>> to have integer defines as well, so we end up with something like:
>>
>> static inline unsigned int get_nmi_count(int cpu)
>> {
>> return CONFIG_X86_64 ? cpu_pda(cpu)->__nmi_count : nmi_count(cpu);
>> }
>>
>
> Unfortunately that doesn't work because when CONFIG_X86_64 isn't defined
> it doesn't expand to 0. It would be nice if CONFIG_* expanded to 0/1,
> but we'd need to change all the #ifdef CONFIG_* to #if CONFIG_*...

Even more important:
How do you want to handle kconfig variables set to "m"?

Expand them to 0.5 ? ;-)

> J

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed